Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1914283003:
mash/browser-tests: Use the correct test-flag for browser-test. (Closed)
|
Created:
4 years, 7 months ago by sadrul Modified:
4 years, 7 months ago Reviewers:
sky CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmash/browser-tests: Use the correct test-flag for browser-test.
'--use-x11-test-config' flag was replaced by '--use-test-config' in
https://crrev.com/388329, but it missed updating the flag used when running
browser-tests in mash.
BUG=594600
Committed: https://crrev.com/23d9fc09311539a683d1c6303a92d4fa6b1663cc
Cr-Commit-Position: refs/heads/master@{#390060}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
sadrul@chromium.org changed reviewers: + sky@chromium.org
LGTM
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914283003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914283003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914283003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914283003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914283003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== mash/browser-tests: Use the correct test-flag for browser-test. '--use-x11-test-config' flag was replaced by '--use-test-config' in https://crrev.com/388329, but it missed updating the flag used when running browser-tests in mash. BUG=594600 ========== to ========== mash/browser-tests: Use the correct test-flag for browser-test. '--use-x11-test-config' flag was replaced by '--use-test-config' in https://crrev.com/388329, but it missed updating the flag used when running browser-tests in mash. BUG=594600 Committed: https://crrev.com/23d9fc09311539a683d1c6303a92d4fa6b1663cc Cr-Commit-Position: refs/heads/master@{#390060} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/23d9fc09311539a683d1c6303a92d4fa6b1663cc Cr-Commit-Position: refs/heads/master@{#390060} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
