Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1914253002: Set framework -install_name to rpath for EarlGrey and OCHamcrest. (Closed)

Created:
4 years, 8 months ago by justincohen
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set framework -install_name to rpath for EarlGrey and OCHamcrest. For binary completeness with Xcode builds. This is also useful for running TEST_HOST binaries outside of an xctest framework. BUG= Committed: https://crrev.com/9b3a5c8e01487937af0cb5b06d0e3e6913a5abc8 Cr-Commit-Position: refs/heads/master@{#390362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M ios/third_party/earl_grey/earl_grey.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/third_party/ochamcrest/ochamcrest.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/ios_web_shell_tests.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
justincohen
ptal
4 years, 8 months ago (2016-04-26 18:24:28 UTC) #2
baxley
lgtm
4 years, 8 months ago (2016-04-26 18:27:56 UTC) #3
justincohen
Over to rohitrao for OWNERS
4 years, 8 months ago (2016-04-26 19:05:27 UTC) #5
rohitrao (ping after 24h)
lgtm
4 years, 7 months ago (2016-04-28 11:56:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914253002/1
4 years, 7 months ago (2016-04-28 12:55:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 13:30:38 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b3a5c8e01487937af0cb5b06d0e3e6913a5abc8
Cr-Commit-Position: refs/heads/master@{#390362}

Powered by Google App Engine
This is Rietveld 408576698