tracing/tracing/ui/base/tab_view.html - Issue 1914243003: Replace instances of shadowRoot with root.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/tab_view.html

Issue 1914243003: Replace instances of shadowRoot with root. (Closed) Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/base/tab_view.html

diff --git a/tracing/tracing/ui/base/tab_view.html b/tracing/tracing/ui/base/tab_view.html

index 48667a7075fe3f9ff3d2605f0932a1a7d032b6bc..94f8b597865d4d18561c7a2740182fd35b624396 100644

--- a/tracing/tracing/ui/base/tab_view.html

+++ b/tracing/tracing/ui/base/tab_view.html

@@ -196,13 +196,13 @@ window.TracingAnalysisTabView = Polymer({

get tabsHidden() {

- var ts = this.shadowRoot.querySelector('tab-strip');

+ var ts = this.root.querySelector('tab-strip');

return ts.hasAttribute('tabs-hidden');

set tabsHidden(tabsHidden) {

tabsHidden = !!tabsHidden;

- var ts = this.shadowRoot.querySelector('tab-strip');

+ var ts = this.root.querySelector('tab-strip');

if (tabsHidden)

ts.setAttribute('tabs-hidden', true);

else

« no previous file with comments | « tracing/tracing/ui/base/resize_sensor.html ('k') | tracing/tracing/ui/timeline_view.html » ('j') | no next file with comments »