components/test_runner/test_plugin.cc - Issue 1914233006: Implement offscreenCanvas.getContext('webgl') on a worker thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_plugin.cc

Issue 1914233006: Implement offscreenCanvas.getContext('webgl') on a worker thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address kbr@'s comments, and limit maxGLActiveContexts=4 per worker thread Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/renderer/renderer_blink_platform_impl.h » ('j') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext-in-worker.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_plugin.cc

diff --git a/components/test_runner/test_plugin.cc b/components/test_runner/test_plugin.cc

index 6e916021fce3f2fd99140938ca41cb20013b6b25..e8793fd4ec9f9a616adc3a404a05f297d5db8748 100644

--- a/components/test_runner/test_plugin.cc

+++ b/components/test_runner/test_plugin.cc

@@ -185,7 +185,7 @@ bool TestPlugin::initialize(blink::WebPluginContainer* container) {

blink::Platform::GraphicsInfo gl_info;

context_provider_ = base::WrapUnique(

blink::Platform::current()->createOffscreenGraphicsContext3DProvider(

- attrs, url, nullptr, &gl_info));

+ attrs, url, nullptr, &gl_info, blink::Platform::BindToCurrentThread));

gl_ = context_provider_ ? context_provider_->contextGL() : nullptr;

if (!InitScene())