Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1914233005: [Mac/GN] Add BUILD.gn file for //chrome/tools/mac_helpers. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-chrome-nibs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Add BUILD.gn file for //chrome/tools/mac_helpers. BUG=431177 R=thakis@chromium.org Committed: https://crrev.com/31cad7ed14e279442c9234c19f8c602f70cea8a2 Cr-Commit-Position: refs/heads/master@{#390505}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix deps #

Patch Set 3 : Fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M chrome/chrome.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/tools/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/tools/mac_helpers/BUILD.gn View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Robert Sesek
4 years, 7 months ago (2016-04-28 20:08:06 UTC) #2
Nico
https://codereview.chromium.org/1914233005/diff/20001/chrome/tools/mac_helpers/BUILD.gn File chrome/tools/mac_helpers/BUILD.gn (right): https://codereview.chromium.org/1914233005/diff/20001/chrome/tools/mac_helpers/BUILD.gn#newcode9 chrome/tools/mac_helpers/BUILD.gn:9: "infoplist_strings_util.mm", this includes "chrome/grit/chromium_strings.h" which I think is a ...
4 years, 7 months ago (2016-04-28 20:13:24 UTC) #3
Robert Sesek
https://codereview.chromium.org/1914233005/diff/20001/chrome/tools/mac_helpers/BUILD.gn File chrome/tools/mac_helpers/BUILD.gn (right): https://codereview.chromium.org/1914233005/diff/20001/chrome/tools/mac_helpers/BUILD.gn#newcode9 chrome/tools/mac_helpers/BUILD.gn:9: "infoplist_strings_util.mm", On 2016/04/28 20:13:24, Nico wrote: > this includes ...
4 years, 7 months ago (2016-04-28 20:27:52 UTC) #4
Nico
lgtm
4 years, 7 months ago (2016-04-28 20:30:33 UTC) #5
Nico
(and maybe clean up the deps list in gyp while here -- probably nice if ...
4 years, 7 months ago (2016-04-28 20:30:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914233005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914233005/60001
4 years, 7 months ago (2016-04-28 20:57:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-04-28 22:14:32 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:59 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31cad7ed14e279442c9234c19f8c602f70cea8a2
Cr-Commit-Position: refs/heads/master@{#390505}

Powered by Google App Engine
This is Rietveld 408576698