tools/perf/measurements/page_cycler.py - Issue 1914233003: [tools/perf] Delete unused variable

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/page_cycler.py

Issue 1914233003: [tools/perf] Delete unused variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/measurements/oilpan_gc_times.py ('k') | tools/perf/measurements/power.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """The page cycler measurement.	5 """The page cycler measurement.

6	6

7 This measurement registers a window load handler in which is forces a layout and	7 This measurement registers a window load handler in which is forces a layout and

8 then records the value of performance.now(). This call to now() measures the	8 then records the value of performance.now(). This call to now() measures the

9 time from navigationStart (immediately after the previous page's beforeunload	9 time from navigationStart (immediately after the previous page's beforeunload

10 event) until after the layout in the page's load event. In addition, two garbage	10 event) until after the layout in the page's load event. In addition, two garbage

(...skipping 135 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
146 # We do the warm runs first for two reasons. The first is so we can	146 # We do the warm runs first for two reasons. The first is so we can

147 # preserve any initial profile cache for as long as possible.	147 # preserve any initial profile cache for as long as possible.

148 # The second is that, if we did cold runs first, we'd have a transition	148 # The second is that, if we did cold runs first, we'd have a transition

149 # page set during which we wanted the run for each URL to both	149 # page set during which we wanted the run for each URL to both

150 # contribute to the cold data and warm the catch for the following	150 # contribute to the cold data and warm the catch for the following

151 # warm run, and clearing the cache before the load of the following	151 # warm run, and clearing the cache before the load of the following

152 # URL would eliminate the intended warmup for the previous URL.	152 # URL would eliminate the intended warmup for the previous URL.

153 return self._has_loaded_page[url] >= self._cold_run_start_index	153 return self._has_loaded_page[url] >= self._cold_run_start_index

154	154

155 def DidRunPage(self, platform):	155 def DidRunPage(self, platform):

	156 del platform # unused

156 self._power_metric.Close()	157 self._power_metric.Close()

OLD	NEW