Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1914183002: Simplify ownership handling of HTMLImportsController. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, tfarina, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify ownership handling of HTMLImportsController. The controller is now simply referred to and kept alive from the associated master Document, detached of and disposed during Document detach. R=haraken BUG=585328 Committed: https://crrev.com/76ce9e386efebcb96166e01aaa942db5facfa23b Cr-Commit-Position: refs/heads/master@{#389814}

Patch Set 1 #

Patch Set 2 : drop Finalized #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -46 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.h View 1 2 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp View 2 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/LinkImport.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-26 14:14:51 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-26 14:26:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914183002/20001
4 years, 8 months ago (2016-04-26 15:06:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 17:30:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 17:32:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76ce9e386efebcb96166e01aaa942db5facfa23b
Cr-Commit-Position: refs/heads/master@{#389814}

Powered by Google App Engine
This is Rietveld 408576698