Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1914143004: Re-enable multi-process IPC tests on Android. (Closed)

Created:
4 years, 8 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-android-tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable multi-process IPC tests on Android. This is possible by using the alternate test child implementation. Committed: https://crrev.com/3f7857b03d9560943c20e88f3802aefe082fcdbf Cr-Commit-Position: refs/heads/master@{#391178}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase for commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -84 lines) Patch
M ipc/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 7 chunks +16 lines, -22 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ipc/run_all_unittests.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +2 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Anand Mistry (off Chromium)
WDYT?
4 years, 8 months ago (2016-04-27 01:07:03 UTC) #2
Tom Sepez
Ok, lets try it. LGTM.
4 years, 7 months ago (2016-04-27 20:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914143004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914143004/40001
4 years, 7 months ago (2016-05-03 05:12:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-03 06:07:07 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3f7857b03d9560943c20e88f3802aefe082fcdbf Cr-Commit-Position: refs/heads/master@{#391178}
4 years, 7 months ago (2016-05-03 06:08:21 UTC) #9
mlamouri (slow - plz ping)
4 years, 7 months ago (2016-05-04 12:53:57 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1950553003/ by mlamouri@chromium.org.

The reason for reverting is: They are breaking various downstream bots:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%...
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/asan-cl....

Powered by Google App Engine
This is Rietveld 408576698