Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1914133002: Out-of-line some methods on LayoutSVGResourceMarker (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
davve
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Out-of-line some methods on LayoutSVGResourceMarker Move the definition of orientType() and markerUnits() to the .cpp file. Also make use of these helpers where possible and remove some unused or redundant includes. Committed: https://crrev.com/849e6cb232603627075eabd6c9287160b73a5e4d Cr-Commit-Position: refs/heads/master@{#389747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 8 months ago (2016-04-26 10:37:53 UTC) #2
davve
lgtm
4 years, 8 months ago (2016-04-26 11:24:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914133002/1
4 years, 8 months ago (2016-04-26 11:30:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 11:48:42 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 11:51:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/849e6cb232603627075eabd6c9287160b73a5e4d
Cr-Commit-Position: refs/heads/master@{#389747}

Powered by Google App Engine
This is Rietveld 408576698