Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: appengine/findit/crash/test/stacktrace_test.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/results_test.py ('k') | appengine/findit/crash/test/stacktrace_test_suite.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/stacktrace_test.py
diff --git a/appengine/findit/crash/test/stacktrace_test.py b/appengine/findit/crash/test/stacktrace_test.py
index 20ac71e40a3103eefe0703806ba197af903ced54..4da9d730a238b64efb49b1a2ce4e4bfa97027c26 100644
--- a/appengine/findit/crash/test/stacktrace_test.py
+++ b/appengine/findit/crash/test/stacktrace_test.py
@@ -12,10 +12,10 @@ from crash.test.stacktrace_test_suite import StacktraceTestSuite
class StacktraceTest(StacktraceTestSuite):
def testCrashStackForStacktraceWithoutSignature(self):
frame_list1 = [
- StackFrame(0, 'src/', '', 'func', 'file0.cc', [32])]
+ StackFrame(0, 'src/', 'func', 'file0.cc', 'src/file0.cc', [32])]
frame_list2 = [
- StackFrame(0, 'src/', '', 'func2', 'file0.cc', [32])]
+ StackFrame(0, 'src/', 'func2', 'file0.cc', 'src/file0.cc', [32])]
stacktrace = Stacktrace([CallStack(0, frame_list=frame_list1),
CallStack(1, frame_list=frame_list2)])
@@ -25,22 +25,25 @@ class StacktraceTest(StacktraceTestSuite):
def testFilterFramesBeforeSignatureForCrashStack(self):
frame_list1 = [
- StackFrame(0, 'src/', '', 'func', 'file0.cc', [32]),
+ StackFrame(0, 'src/', 'func', 'file0.cc', 'src/file0.cc', [32]),
]
callstack1 = CallStack(0, frame_list=frame_list1)
frame_list2 = [
- StackFrame(0, 'src/', '', 'func', 'file0.cc', [32]),
- StackFrame(1, 'src/', '', 'signature_func', 'file1.cc', [53]),
- StackFrame(2, 'src/', '', 'funcc', 'file2.cc', [3])
+ StackFrame(0, 'src/', 'func', 'file0.cc', 'src/file0.cc', [32]),
+ StackFrame(1, 'src/', 'signature_func',
+ 'file1.cc', 'src/file1.cc', [53]),
+ StackFrame(2, 'src/', 'funcc', 'file2.cc', 'src/file2.cc', [3])
]
callstack2 = CallStack(0, frame_list=frame_list2)
stacktrace = Stacktrace([callstack1, callstack2], 'signature')
expected_frame_list = [
- StackFrame(1, 'src/', '', 'signature_func', 'file1.cc', [53]),
- StackFrame(2, 'src/', '', 'funcc', 'file2.cc', [3])]
+ StackFrame(
+ 1, 'src/', 'signature_func', 'file1.cc', 'src/file1.cc', [53]),
+ StackFrame(
+ 2, 'src/', 'funcc', 'file2.cc', 'src/file2.cc', [3])]
expected_crash_stack = CallStack(0, frame_list=expected_frame_list)
self._VerifyTwoCallStacksEqual(stacktrace.crash_stack,
@@ -48,7 +51,7 @@ class StacktraceTest(StacktraceTestSuite):
def testNoSignatureMatchForCrashStack(self):
frame_list = [
- StackFrame(0, 'src/', '', 'func', 'file0.cc', [32]),
+ StackFrame(0, 'src/', 'func', 'file0.cc', 'src/file0.cc', [32]),
]
callstack = CallStack(0, frame_list=frame_list)
« no previous file with comments | « appengine/findit/crash/test/results_test.py ('k') | appengine/findit/crash/test/stacktrace_test_suite.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698