Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2155)

Unified Diff: appengine/findit/crash/results.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/results.py
diff --git a/appengine/findit/crash/results.py b/appengine/findit/crash/results.py
index 2daa564a5c1c2fc4886ad0f85e4c7203b6e74485..cb24f1968cc60fa5cfc0927106dd7f4951fdc6e0 100644
--- a/appengine/findit/crash/results.py
+++ b/appengine/findit/crash/results.py
@@ -8,11 +8,10 @@ _INFINITY = 1000
class Result(object):
"""Represents findit culprit result."""
- def __init__(self, changelog, dep_path, component,
+ def __init__(self, changelog, dep_path,
confidence=None, reason=None):
self.changelog = changelog
self.dep_path = dep_path
- self.component = component
self.confidence = confidence
self.reason = reason
@@ -52,10 +51,10 @@ class Result(object):
class MatchResult(Result):
"""Represents findit culprit result got from match algorithm."""
- def __init__(self, changelog, dep_path, component,
+ def __init__(self, changelog, dep_path,
confidence=None, reason=None):
super(MatchResult, self).__init__(
- changelog, dep_path, component, confidence, reason)
+ changelog, dep_path, confidence, reason)
self.min_distance = _INFINITY
@@ -132,10 +131,7 @@ class MatchResults(dict):
continue
if changelog.revision not in self:
- # TODO(katesonia): Enable component classifier later. Get it from
- # file_path and dep_path.
- component = ''
- self[changelog.revision] = MatchResult(changelog, dep_path, component)
+ self[changelog.revision] = MatchResult(changelog, dep_path)
match_result = self[changelog.revision]
« no previous file with comments | « appengine/findit/crash/project_classifier.py ('k') | appengine/findit/crash/scorers/test/aggregator_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698