Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: appengine/findit/crash/fracas.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/component_classifier.py ('k') | appengine/findit/crash/fracas_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/fracas.py
diff --git a/appengine/findit/crash/fracas.py b/appengine/findit/crash/fracas.py
index bf2d1e937495c9dfc2054b6da905c1810b648445..612b938cafbc6f8a75c786e10213b5feca8e5190 100644
--- a/appengine/findit/crash/fracas.py
+++ b/appengine/findit/crash/fracas.py
@@ -8,6 +8,8 @@ from common import chromium_deps
from crash import detect_regression_range
from crash import findit_for_crash
from crash.fracas_parser import FracasParser
+from crash.project_classifier import ProjectClassifier
+from crash.component_classifier import ComponentClassifier
def FindCulpritForChromeCrash(signature, platform,
@@ -80,9 +82,11 @@ def FindCulpritForChromeCrash(signature, platform,
culprit_results = findit_for_crash.FindItForCrash(
stacktrace, regression_deps_rolls, crash_deps)
- # TODO(katesonia): Enable dependency classifier and component classifier.
- suspected_project = ''
- suspected_components = []
+ crash_stack = stacktrace.crash_stack
+ suspected_project = ProjectClassifier().Classify(
+ culprit_results, crash_stack)
+ suspected_components = ComponentClassifier().Classify(
+ culprit_results, crash_stack)
return (
{
« no previous file with comments | « appengine/findit/crash/component_classifier.py ('k') | appengine/findit/crash/fracas_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698