Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: appengine/findit/crash/test/findit_for_crash_test.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/findit_for_crash_test.py
diff --git a/appengine/findit/crash/test/findit_for_crash_test.py b/appengine/findit/crash/test/findit_for_crash_test.py
index 67922260f9294232a1609fb361f0a9db99bda0b2..921077e76ad4c7b3b4104104add9aa3c185bdde2 100644
--- a/appengine/findit/crash/test/findit_for_crash_test.py
+++ b/appengine/findit/crash/test/findit_for_crash_test.py
@@ -95,8 +95,8 @@ class FinditForCrashTest(CrashTestSuite):
def testGetDepsInCrashStack(self):
crash_stack = CallStack(0)
crash_stack.extend([
- StackFrame(0, 'src/', '', 'func0', 'f0.cc', [1]),
- StackFrame(1, 'src/', '', 'func1', 'f1.cc', [2, 3]),
+ StackFrame(0, 'src/', 'func0', 'f0.cc', 'src/f0.cc', [1]),
+ StackFrame(1, 'src/', 'func1', 'f1.cc', 'src/f1.cc', [2, 3]),
])
crash_deps = {'src/': Dependency('src/', 'https://chromium_repo', '1'),
'src/v8/': Dependency('src/v8/', 'https://v8_repo', '2')}
@@ -162,13 +162,13 @@ class FinditForCrashTest(CrashTestSuite):
main_stack = CallStack(0)
main_stack.extend(
- [StackFrame(0, 'src/', '', 'c(p* &d)', 'a.cc', [177]),
- StackFrame(1, 'src/', '', 'd(a* c)', 'a.cc', [227, 228, 229]),
- StackFrame(2, 'src/v8/', '', 'e(int)', 'b.cc', [87, 88, 89, 90])])
+ [StackFrame(0, 'src/', 'c(p* &d)', 'a.cc', 'src/a.cc', [177]),
+ StackFrame(1, 'src/', 'd(a* c)', 'a.cc', 'src/a.cc', [227, 228, 229]),
+ StackFrame(2, 'src/v8/', 'e(int)', 'b.cc', 'src/v8/b.cc', [89, 90])])
low_priority_stack = CallStack(1)
low_priority_stack.append(
- StackFrame(0, 'src/dummy/', '', 'c(p* &d)', 'd.cc', [17]))
+ StackFrame(0, 'src/dummy/', 'c(p* &d)', 'd.cc', 'src/dummy/d.cc', [17]))
stacktrace = Stacktrace()
stacktrace.extend([main_stack, low_priority_stack])
@@ -222,12 +222,12 @@ class FinditForCrashTest(CrashTestSuite):
main_stack = CallStack(0)
main_stack.extend(
- [StackFrame(0, 'src/', '', 'c(p* &d)', 'a.cc', [177]),
- StackFrame(1, 'src/', '', 'd(a* c)', 'a.cc', [227, 228, 229])])
+ [StackFrame(0, 'src/', 'c(p* &d)', 'a.cc', 'src/a.cc', [177]),
+ StackFrame(1, 'src/', 'd(a* c)', 'a.cc', 'src/a.cc', [227, 228, 229])])
low_priority_stack = CallStack(1)
low_priority_stack.append(
- StackFrame(0, 'dummy_dep/', '', 'k(p* &d)', 'h.cc', [17]))
+ StackFrame(0, 'dummy_dep/', 'k(p* &d)', 'h.cc', 'dummy_dep/h.cc', [17]))
stacktrace = Stacktrace()
stacktrace.extend([main_stack, low_priority_stack])
@@ -267,11 +267,11 @@ class FinditForCrashTest(CrashTestSuite):
dep_file_to_stack_infos = {
'src/': {
'a.cc': [
- (StackFrame(0, 'src/', '', 'func', 'a.cc', [1]), 0),
- (StackFrame(1, 'src/', '', 'func', 'a.cc', [7]), 0),
+ (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
+ (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
],
'b.cc': [
- (StackFrame(2, 'src/', '', 'func', 'b.cc', [36]), 0),
+ (StackFrame(2, 'src/', 'func', 'b.cc', 'src/b.cc', [36]), 0),
]
}
}
@@ -292,7 +292,6 @@ class FinditForCrashTest(CrashTestSuite):
'url': 'https://repo.test/+/1',
'revision': '1',
'dep_path': 'src/',
- 'component': '',
'author': 'r@chromium.org',
'time': 'Thu Mar 31 21:24:43 2016',
'reason': None,
@@ -328,8 +327,8 @@ class FinditForCrashTest(CrashTestSuite):
match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
match_result1.file_to_stack_infos = {
'a.cc': [
- (StackFrame(0, 'src/', '', 'func', 'a.cc', [1]), 0),
- (StackFrame(1, 'src/', '', 'func', 'a.cc', [7]), 0),
+ (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
+ (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
]
}
match_result1.min_distance = 0
@@ -337,7 +336,7 @@ class FinditForCrashTest(CrashTestSuite):
match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
match_result2.file_to_stack_infos = {
'f.cc': [
- (StackFrame(5, 'src/', '', 'func', 'f.cc', [1]), 0),
+ (StackFrame(5, 'src/', 'func', 'f.cc', 'src/f.cc', [1]), 0),
]
}
match_result2.min_distance = 20
@@ -351,7 +350,6 @@ class FinditForCrashTest(CrashTestSuite):
'url': 'https://repo.test/+/1',
'revision': '1',
'dep_path': 'src/',
- 'component': '',
'author': 'r@chromium.org',
'time': 'Thu Mar 31 21:24:43 2016',
'reason': ('1. Top frame changed is frame #0 (score: 1)\n'
@@ -364,7 +362,6 @@ class FinditForCrashTest(CrashTestSuite):
'url': 'https://repo.test/+/3',
'revision': '3',
'dep_path': 'src/',
- 'component': '',
'author': 'e@chromium.org',
'time': 'Thu Apr 1 21:24:43 2016',
'reason': ('1. Top frame changed is frame #5 (score: 0)\n'

Powered by Google App Engine
This is Rietveld 408576698