Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: appengine/findit/crash/fracas_parser.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/fracas_parser.py
diff --git a/appengine/findit/crash/fracas_parser.py b/appengine/findit/crash/fracas_parser.py
index a4b967270c99c7ef55d0f4b71052fca4ce3efef4..478769db65c4ae4512eb52b3974a9adce1faef09 100644
--- a/appengine/findit/crash/fracas_parser.py
+++ b/appengine/findit/crash/fracas_parser.py
@@ -4,6 +4,7 @@
import re
+from common import constants
from crash.callstack import CallStack
from crash.stacktrace import Stacktrace
from crash.stacktrace_parser import StacktraceParser
@@ -13,15 +14,12 @@ from crash.type_enums import CallStackFormatType
FRACAS_CALLSTACK_START_PATTERN = re.compile(r'CRASHED \[(.*) @ 0x(.*)\]')
-_INFINITY_PRIORITY = 1000
-
-
class FracasParser(StacktraceParser):
def Parse(self, stacktrace_string, deps):
"""Parse fracas stacktrace string into Stacktrace instance."""
stacktrace = Stacktrace()
- callstack = CallStack(_INFINITY_PRIORITY)
+ callstack = CallStack(constants.INFINITY)
for line in stacktrace_string.splitlines():
is_new_callstack, stack_priority, format_type = (
@@ -30,14 +28,14 @@ class FracasParser(StacktraceParser):
if is_new_callstack:
# If the callstack is not the initial one or empty, add it
# to stacktrace.
- if callstack.priority != _INFINITY_PRIORITY and callstack:
+ if callstack.priority != constants.INFINITY and callstack:
stacktrace.append(callstack)
callstack = CallStack(stack_priority, format_type)
else:
callstack.ParseLine(line, deps)
- if callstack.priority != _INFINITY_PRIORITY and callstack:
+ if callstack.priority != constants.INFINITY and callstack:
stacktrace.append(callstack)
return stacktrace

Powered by Google App Engine
This is Rietveld 408576698