Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: appengine/findit/crash/test/project_classifier_test.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/crash/test/fracas_test.py ('k') | appengine/findit/crash/test/results_test.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 from crash.callstack import StackFrame, CallStack
6 from crash.project_classifier import ProjectClassifier
7 from crash.results import Result
8 from crash.test.crash_testcase import CrashTestCase
9 from crash.type_enums import CallStackLanguageType
10 from model.crash.crash_config import CrashConfig
11
12
13 class ProjectClassifierTest(CrashTestCase):
14
15 def testGetProjectNameFromDepPath(self):
16 classifier = ProjectClassifier()
17 self.assertEqual(classifier._GetProjectFromDepPath('src/'),
18 'chromium')
19
20 self.assertEqual(classifier._GetProjectFromDepPath('src/abc'),
21 'chromium-abc')
22
23 self.assertEqual(classifier._GetProjectFromDepPath('unknown/unknown'),
24 'chromium-unknown_unknown')
25
26 def testGetClassFromStackFrame(self):
27 classifier = ProjectClassifier()
28
29 frame = StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [2])
30 self.assertEqual(
31 classifier.GetClassFromStackFrame(frame), 'chromium')
32
33 frame = StackFrame(0, '', 'android.a', 'comp1.cc', 'src/comp1.cc', [2])
34 self.assertEqual(
35 classifier.GetClassFromStackFrame(frame), 'android_os')
36
37 frame = StackFrame(0, '', 'func', 'comp2.cc',
38 'googleplex-android/src/comp2.cc', [32])
39 self.assertEqual(
40 classifier.GetClassFromStackFrame(frame), 'android_os')
41
42 frame = StackFrame(0, '', 'func', 'comp2.cc', 'unknown/comp2.cc', [32])
43 self.assertEqual(
44 classifier.GetClassFromStackFrame(frame), '')
45
46 def testGetClassFromResult(self):
47 classifier = ProjectClassifier()
48
49 result = Result(self.GetDummyChangeLog(), 'src/')
50 result.file_to_stack_infos = {'a.cc': [(
51 StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [3]), 0
52 )]}
53 self.assertEqual(classifier.GetClassFromResult(result), 'chromium')
54
55 result.file_to_stack_infos = {
56 'comp1.cc': [
57 (StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]), 0)
58 ]
59 }
60 self.assertEqual(classifier.GetClassFromResult(result), 'chromium')
61
62 def testClassifyCrashStack(self):
63 classifier = ProjectClassifier()
64
65 crash_stack = CallStack(0)
66 crash_stack.extend([
67 StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]),
68 StackFrame(1, 'src/', 'ff', 'comp1.cc', 'src/comp1.cc', [21]),
69 StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])
70 ])
71
72 self.assertEqual(classifier.Classify([], crash_stack), 'chromium')
73
74 def testClassifyResultsEmpty(self):
75 classifier = ProjectClassifier()
76
77 result = Result(self.GetDummyChangeLog(), '')
78 self.assertEqual(classifier.Classify([result], CallStack(0)),
79 '')
80
81 def testClassifyRankFunction(self):
82 classifier = ProjectClassifier()
83
84 result1 = Result(self.GetDummyChangeLog(), 'src/')
85 result1.file_to_stack_infos = {
86 'comp1.cc': [
87 (StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]), 0)
88 ]
89 }
90
91 self.assertEqual(classifier.Classify([result1], CallStack(0)), 'chromium')
92
93 result2 = Result(self.GetDummyChangeLog(), '')
94 result2.file_to_stack_infos = {
95 'ad.cc': [
96 (StackFrame(0, '', 'android.a', 'ad.cc', 'ad.cc', [2]), 0)
97 ]
98 }
99
100 self.assertEqual(classifier.Classify([result2], CallStack(0)),
101 'android_os')
102
103 self.assertEqual(classifier.Classify([result1, result2], CallStack(0)),
104 'chromium')
105
106 def testClassifyForJavaRankFunction(self):
107 classifier = ProjectClassifier()
108
109 crash_stack = CallStack(0)
110 crash_stack.language_type = CallStackLanguageType.JAVA
111
112 crash_stack.extend([
113 StackFrame(0, '', 'android.a.f', 'android/a/cc',
114 'android/a.java', [2]),
115 StackFrame(1, '', 'org.chromium.c', 'org/chromium/c.java',
116 'org/chromium/c.java', [8])
117 ])
118
119 self.assertEqual(classifier.Classify([], crash_stack),
120 'chromium')
121
122 def testClassifyReturnsNone(self):
123 def _MockClassify(*_, **args):
124 self.assertIsNotNone(args)
125 return None
126
127 self.mock(ProjectClassifier, '_Classify', _MockClassify)
128
129 classifier = ProjectClassifier()
130 self.assertEqual(classifier.Classify([], CallStack(0)),
131 '')
132
133 def testProjectClassifierDoNotHaveConfig(self):
134 crash_config = CrashConfig.Get()
135 crash_config.project_classifier = {}
136 crash_config.put()
137
138 crash_stack = CallStack(0)
139 crash_stack.extend([
140 StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]),
141 StackFrame(1, 'src/', 'ff', 'comp1.cc', 'src/comp1.cc', [21]),
142 StackFrame(2, 'src/', 'func2', 'comp2.cc', 'src/comp2.cc', [8])
143 ])
144
145 result1 = Result(self.GetDummyChangeLog(), 'src/')
146 result1.file_to_stack_infos = {
147 'comp1.cc': [
148 (StackFrame(0, 'src/', 'func', 'comp1.cc', 'src/comp1.cc', [2]), 0)
149 ]
150 }
151
152 self.assertEqual(ProjectClassifier().Classify([result1], crash_stack), '')
153
154 def testSortHosts(self):
155 host_list = [
156 'src/',
157 'src/chrome/browser/resources/',
158 'src/media/',
159 'src/sdch/',
160 'src/testing/',
161 'src/third_party/WebKit/',
162 'src/third_party/',
163 'src/tools/',
164 'src/chrome/test/data/layout_tests/'
165 ]
166
167 crash_config = CrashConfig.Get()
168 crash_config.project_classifier['host_directories'] = host_list
169
170 expected_sorted_host_list = [
171 'src/chrome/test/data/layout_tests/',
172 'src/chrome/browser/resources/',
173 'src/third_party/WebKit/',
174 'src/media/',
175 'src/sdch/',
176 'src/testing/',
177 'src/third_party/',
178 'src/tools/',
179 'src/'
180 ]
181
182 self.assertEqual(
183 ProjectClassifier().project_classifier_config['host_directories'],
184 expected_sorted_host_list)
OLDNEW
« no previous file with comments | « appengine/findit/crash/test/fracas_test.py ('k') | appengine/findit/crash/test/results_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698