[Findit] Enable project classifier and component classifier

appengine/findit/crash/test/findit_for_crash_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 
 from common.blame import Region, Blame
 from common.change_log import ChangeLog
 from common.dependency import Dependency, DependencyRoll
 from common.git_repository import GitRepository
@@ skipping 77 matching lines @@
     'revision': '3',
     'reverted_revision': None
 })
 
 
 class FinditForCrashTest(CrashTestSuite):
 
   def testGetDepsInCrashStack(self):
     crash_stack = CallStack(0)
     crash_stack.extend([
-        StackFrame(0, 'src/', '', 'func0', 'f0.cc', [1]),
-        StackFrame(1, 'src/', '', 'func1', 'f1.cc', [2, 3]),
-        StackFrame(1, '', '', 'func1', 'f1.cc', [3]),
+        StackFrame(0, 'src/', 'func0', 'f0.cc', 'src/f0.cc', [1]),
+        StackFrame(1, 'src/', 'func1', 'f1.cc', 'src/f1.cc', [2, 3]),
+        StackFrame(1, '', 'func2', 'f2.cc', 'src/f2.cc', [2, 3]),
     ])
     crash_deps = {'src/': Dependency('src/', 'https://chromium_repo', '1'),
                   'src/v8/': Dependency('src/v8/', 'https://v8_repo', '2')}
 
     expected_stack_deps = {'src/': crash_deps['src/']}
 
     self.assertEqual(
         findit_for_crash.GetDepsInCrashStack(crash_stack, crash_deps),
         expected_stack_deps)
 
@@ skipping 31 matching lines @@
         }
     }
     self.assertEqual(dep_file_to_changelogs_json,
                      expected_dep_file_to_changelogs_json)
     self.assertEqual(ignore_cls, set(['1']))
 
   def testGetStackInfosForFilesGroupedByDeps(self):
 
     main_stack = CallStack(0)
     main_stack.extend(
-        [StackFrame(0, 'src/', '', 'c(p* &d)', 'a.cc', [177]),
-         StackFrame(1, 'src/', '', 'd(a* c)', 'a.cc', [227, 228, 229]),
-         StackFrame(2, 'src/v8/', '', 'e(int)', 'b.cc', [87, 88, 89, 90])])
+        [StackFrame(0, 'src/', 'c(p* &d)', 'a.cc', 'src/a.cc', [177]),
+         StackFrame(1, 'src/', 'd(a* c)', 'a.cc', 'src/a.cc', [227, 228, 229]),
+         StackFrame(2, 'src/v8/', 'e(int)', 'b.cc', 'src/v8/b.cc', [89, 90])])
 
     low_priority_stack = CallStack(1)
     low_priority_stack.append(
-        StackFrame(0, 'src/dummy/', '', 'c(p* &d)', 'd.cc', [17]))
+        StackFrame(0, 'src/dummy/', 'c(p* &d)', 'd.cc', 'src/dummy/d.cc', [17]))
 
     stacktrace = Stacktrace()
     stacktrace.extend([main_stack, low_priority_stack])
 
     crashed_deps = {'src/': Dependency('src/', 'https//repo', '2'),
                     'src/v8/': Dependency('src/v8', 'https//repo', '1')}
 
     expected_dep_file_to_stack_infos = {
         'src/': {
             'a.cc': [
@@ skipping 30 matching lines @@
         'src/': {
             'a.cc': [
                 DUMMY_CHANGELOG1,
             ]
         }
     }
 
     dep_file_to_stack_infos = {
         'src/': {
             'a.cc': [
-                (StackFrame(0, 'src/', '', 'func', 'a.cc', [1]), 0),
-                (StackFrame(1, 'src/', '', 'func', 'a.cc', [7]), 0),
+                (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
+                (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
             ],
             'b.cc': [
-                (StackFrame(2, 'src/', '', 'func', 'b.cc', [36]), 0),
+                (StackFrame(2, 'src/', 'func', 'b.cc', 'src/b.cc', [36]), 0),
             ]
         }
     }
 
     dummy_blame = Blame('9', 'a.cc')
     dummy_blame.AddRegion(
         Region(1, 5, '6', 'a', 'a@chromium.org', 'Thu Mar 31 21:24:43 2016'))
     dummy_blame.AddRegion(
         Region(6, 10, '1', 'b', 'b@chromium.org', 'Thu Jun 19 12:11:40 2015'))
 
@@ skipping 19 matching lines @@
 
     expected_dep_to_changed_file_to_blame = {'src/': {'a.cc': dummy_blame}}
 
     match_results, dep_to_changed_file_to_blame = (
         findit_for_crash.FindMatchResults(
             dep_file_to_changelogs, dep_file_to_stack_infos, stack_deps))
     self.assertEqual([result.ToDict() for result in match_results],
                      expected_match_results)
 
     for file_path, blame in dep_to_changed_file_to_blame.iteritems():
-      print dep_to_changed_file_to_blame
       self.assertTrue(file_path in expected_dep_to_changed_file_to_blame)
       self.assertEqual(blame, expected_dep_to_changed_file_to_blame[file_path])
 
   def testFindItForCrashNoRegressionRange(self):
     self.assertEqual(
         findit_for_crash.FindItForCrash(Stacktrace(), {}, {}),
         [])
 
   def testFindItForCrashNoMatchFound(self):
 
     def _MockFindMatchResults(*_):
       return [], {}
 
     self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
 
     regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
                                                     '1', '2')}
     self.assertEqual(findit_for_crash.FindItForCrash(
         Stacktrace(), regression_deps_rolls, {}), [])
 
   def testFindItForCrash(self):
 
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       match_result1.file_to_stack_infos = {
           'a.cc': [
-              (StackFrame(0, 'src/', '', 'func', 'a.cc', [1]), 0),
-              (StackFrame(1, 'src/', '', 'func', 'a.cc', [7]), 0),
+              (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
+              (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
           ]
       }
       match_result1.min_distance = 0
 
       match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       match_result2.file_to_stack_infos = {
           'f.cc': [
-              (StackFrame(5, 'src/', '', 'func', 'f.cc', [1]), 0),
+              (StackFrame(5, 'src/', 'func', 'f.cc', 'src/f.cc', [1]), 0),
           ]
       }
       match_result2.min_distance = 20
 
       return [match_result1, match_result2], {}
 
     self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
 
     expected_match_results = [
         {
@@ skipping 13 matching lines @@
                                                     '1', '2')}
 
     self.assertEqual(findit_for_crash.FindItForCrash(
         Stacktrace(), regression_deps_rolls, {}), expected_match_results)
 
   def testFinditForCrashFilterZeroConfidentResults(self):
     def _MockFindMatchResults(*_):
       match_result1 = MatchResult(DUMMY_CHANGELOG1, 'src/', '')
       match_result1.file_to_stack_infos = {
           'a.cc': [
-              (StackFrame(0, 'src/', '', 'func', 'a.cc', [1]), 0),
-              (StackFrame(1, 'src/', '', 'func', 'a.cc', [7]), 0),
+              (StackFrame(0, 'src/', 'func', 'a.cc', 'src/a.cc', [1]), 0),
+              (StackFrame(1, 'src/', 'func', 'a.cc', 'src/a.cc', [7]), 0),
           ]
       }
       match_result1.min_distance = 1
 
       match_result2 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       match_result2.file_to_stack_infos = {
           'f.cc': [
-              (StackFrame(15, 'src/', '', 'func', 'f.cc', [1]), 0),
+              (StackFrame(15, 'src/', 'func', 'f.cc', 'src/f.cc', [1]), 0),
           ]
       }
       match_result2.min_distance = 20
 
       match_result3 = MatchResult(DUMMY_CHANGELOG3, 'src/', '')
       match_result3.file_to_stack_infos = {
           'f.cc': [
-              (StackFrame(3, 'src/', '', 'func', 'ff.cc', [1]), 0),
+              (StackFrame(3, 'src/', 'func', 'ff.cc', 'src/ff.cc', [1]), 0),
           ]
       }
       match_result3.min_distance = 60
 
       return [match_result1, match_result2, match_result3], {}
 
     self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
 
     expected_match_results = [
         {
@@ skipping 35 matching lines @@
 
       return [match_result1, match_result2], {}
 
     self.mock(findit_for_crash, 'FindMatchResults', _MockFindMatchResults)
 
     regression_deps_rolls = {'src/': DependencyRoll('src/', 'https://repo',
                                                     '1', '2')}
 
     self.assertEqual(findit_for_crash.FindItForCrash(
         Stacktrace(), regression_deps_rolls, {}), [])