[Findit] Enable project classifier and component classifier

appengine/findit/crash/callstack.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from crash import parse_util
 from crash.type_enums import CallStackFormatType
 
 # Used to parse a line into StackFrame of a Callstack.
@@ skipping 11 matching lines @@
 
 
 class StackFrame(object):
   """Represents a frame in a stacktrace.
 
   Attributes:
     index (int): Index shown in the stacktrace if a stackframe line looks like
       this - '#0 ...', else use the index in the callstack list.
     dep_path (str): Path of the dep this frame represents, for example,
       'src/', 'src/v8', 'src/skia'...etc.
-    component (str): Component of this frame, for example, 'Blink>API'.
     function (str): Function that caused the crash.
-    file_path (str): Path of the crashed file.
+    file_path (str): Normalized path of the crashed file, with parts dep_path
+      and parts before it stripped.
+    raw_file_path (str): Normalized original path of the crashed file.

[stgao, 2016/05/17 21:40:57]

Maybe give two examples here for the file paths?

[Sharu Jiang, 2016/05/20 23:16:32]

Done.

     crashed_line_numbers (list): Line numbers of the file that caused the crash.
   """
-  def __init__(self, index, dep_path, component,
-               function, file_path, crashed_line_numbers):
+  def __init__(self, index, dep_path, function,
+               file_path, raw_file_path, crashed_line_numbers):
     self.index = index
     self.dep_path = dep_path
-    self.component = component
     self.function = function
     self.file_path = file_path
+    self.raw_file_path = raw_file_path
     self.crashed_line_numbers = crashed_line_numbers
 
   def ToString(self):
     frame_str = '#%d in %s @ %s' % (self.index, self.function, self.file_path)
     if self.crashed_line_numbers:
       frame_str += ':%d' % self.crashed_line_numbers[0]
 
     # For example, if crashed_line_numbers is [61], returns '... f.cc:61',
     # if is [61, 62], returns '... f.cc:61:1'
     if len(self.crashed_line_numbers) > 1:
@@ skipping 35 matching lines @@
     parsed."""
     line = line.strip()
     line_pattern = CALLSTACK_FORMAT_TO_PATTERN[self.format_type]
 
     if self.format_type == CallStackFormatType.JAVA:
       match = line_pattern.match(line)
       if not match:
         return
 
       function = match.group(1)
-      file_path = parse_util.GetFullPathForJavaFrame(function)
+      raw_file_path = parse_util.GetFullPathForJavaFrame(function)
       crashed_line_numbers = [int(match.group(3))]
 
     elif self.format_type == CallStackFormatType.SYZYASAN:
       match = line_pattern.match(line)
       if not match:
         return
 
       function = match.group(2).strip()
-      file_path = match.group(5)
+      raw_file_path = match.group(5)
       crashed_line_numbers = [int(match.group(6))]
 
     else:
       line_parts = line.split()
       if not line_parts or not line_parts[0].startswith('#'):
         return
 
       match = line_pattern.match(line_parts[-1])
       if not match:
         return
 
       function = ' '.join(line_parts[3:-1])
-      file_path = match.group(1)
+      raw_file_path = match.group(1)
       crashed_line_numbers = parse_util.GetCrashedLineRange(
           match.group(2) + (match.group(3) if match.group(3) else ''))
 
     # Normalize the file path so that it can be compared to repository path.
     dep_path, file_path = parse_util.GetDepPathAndNormalizedFilePath(
-        file_path, deps)
-
-    #TODO(katesonia): Enable component classifier later.
-    component = ''
+        raw_file_path, deps)
 
     # If we have the common stack frame index pattern, then use it
     # since it is more reliable.
     index_match = FRAME_INDEX_PATTERN.match(line)
     if index_match:
       stack_frame_index = int(index_match.group(1))
     else:
       stack_frame_index = len(self)
 
-    self.append(StackFrame(stack_frame_index, dep_path, component,
-                           function, file_path, crashed_line_numbers))
+    self.append(StackFrame(stack_frame_index, dep_path, function,
+                           file_path, raw_file_path, crashed_line_numbers))