Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1914103002: GN: Respect system libdir whenever building with the traget sysroot (Closed)

Created:
4 years, 8 months ago by hashimoto
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Respect system libdir whenever building with the traget sysroot Nacl uses its own toolchain with the target sysroot. System libdir should be respected with that toolchain too. BUG=606432 Committed: https://crrev.com/a82baa163c5969ef8f4733ecfeb5fe20cf51cd13 Cr-Commit-Position: refs/heads/master@{#389830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/linux/pkg_config.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hashimoto
4 years, 8 months ago (2016-04-26 04:53:00 UTC) #2
stevenjb
+brettw@ Currently this is blocking cros developers switching to GN (and I don't want to ...
4 years, 8 months ago (2016-04-26 17:52:15 UTC) #4
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-26 18:19:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914103002/1
4 years, 8 months ago (2016-04-26 18:25:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 18:57:46 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 18:59:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a82baa163c5969ef8f4733ecfeb5fe20cf51cd13
Cr-Commit-Position: refs/heads/master@{#389830}

Powered by Google App Engine
This is Rietveld 408576698