chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 1914073005: Make getFaviconImageSet work with all expected URL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 1914073005: Make getFaviconImageSet work with all expected URL types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 024e62f8d09918e3a3dac33ade7aa40a2df0acf9..f923740048d6b5b3584ac2a5d3f1fd6f958c447d 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -123,8 +123,7 @@ cr.define('options.search_engines', function() {

var faviconDivEl = this.ownerDocument.createElement('div');

faviconDivEl.className = 'favicon';

if (!this.isPlaceholder) {

- faviconDivEl.style.backgroundImage = imageset(

- 'chrome://favicon/size/16@scalefactorx/iconurl/' + engine.iconURL);

+ faviconDivEl.style.backgroundImage = getFaviconImageSet(engine.iconURL);

}

Dan Beam 2016/04/27 02:18:31 no curlies

dpapad 2016/04/27 17:21:47 Done.

nameColEl.appendChild(faviconDivEl);

« no previous file with comments | « no previous file | chrome/test/data/webui/util_test.html » ('j') | chrome/test/data/webui/util_test.html » ('J')