Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 1914073005: Make getFaviconImageSet work with all expected URL types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: case insensitive Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/util_test.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{canBeDefault: boolean, 6 * @typedef {{canBeDefault: boolean,
7 * canBeEdited: boolean, 7 * canBeEdited: boolean,
8 * canBeRemoved: boolean, 8 * canBeRemoved: boolean,
9 * default: boolean, 9 * default: boolean,
10 * displayName: string, 10 * displayName: string,
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 // Construct the name column. 116 // Construct the name column.
117 var nameColEl = this.ownerDocument.createElement('div'); 117 var nameColEl = this.ownerDocument.createElement('div');
118 nameColEl.className = 'name-column'; 118 nameColEl.className = 'name-column';
119 nameColEl.classList.add('weakrtl'); 119 nameColEl.classList.add('weakrtl');
120 this.contentElement.appendChild(nameColEl); 120 this.contentElement.appendChild(nameColEl);
121 121
122 // Add the favicon. 122 // Add the favicon.
123 var faviconDivEl = this.ownerDocument.createElement('div'); 123 var faviconDivEl = this.ownerDocument.createElement('div');
124 faviconDivEl.className = 'favicon'; 124 faviconDivEl.className = 'favicon';
125 if (!this.isPlaceholder) { 125 if (!this.isPlaceholder)
126 faviconDivEl.style.backgroundImage = imageset( 126 faviconDivEl.style.backgroundImage = getFaviconImageSet(engine.iconURL);
127 'chrome://favicon/size/16@scalefactorx/iconurl/' + engine.iconURL); 127
128 }
129 nameColEl.appendChild(faviconDivEl); 128 nameColEl.appendChild(faviconDivEl);
130 129
131 var nameEl = this.createEditableTextCell(engine.displayName); 130 var nameEl = this.createEditableTextCell(engine.displayName);
132 nameEl.classList.add('weakrtl'); 131 nameEl.classList.add('weakrtl');
133 nameColEl.appendChild(nameEl); 132 nameColEl.appendChild(nameEl);
134 133
135 // Then the keyword column. 134 // Then the keyword column.
136 var keywordEl = this.createEditableTextCell(engine.keyword); 135 var keywordEl = this.createEditableTextCell(engine.keyword);
137 keywordEl.className = 'keyword-column'; 136 keywordEl.className = 'keyword-column';
138 keywordEl.classList.add('weakrtl'); 137 keywordEl.classList.add('weakrtl');
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 }, 367 },
369 }; 368 };
370 369
371 // Export 370 // Export
372 return { 371 return {
373 SearchEngineList: SearchEngineList 372 SearchEngineList: SearchEngineList
374 }; 373 };
375 374
376 }); 375 });
377 376
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/util_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698