[mojo-edk] Fix lifetime management of rewritten Windows HANDLEs

mojo/edk/system/channel.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/channel.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <limits>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/memory/aligned_memory.h"
+#include "base/process/process_handle.h"
 #include "mojo/edk/embedder/platform_handle.h"
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 #include "base/mac/mach_logging.h"
 #endif
 
 namespace mojo {
 namespace edk {
 
 namespace {
@@ skipping 298 matching lines @@
 bool Channel::Message::RewriteHandles(base::ProcessHandle from_process,
                                       base::ProcessHandle to_process,
                                       PlatformHandle* handles,
                                       size_t num_handles) {
   bool success = true;
   for (size_t i = 0; i < num_handles; ++i) {
     if (!handles[i].is_valid()) {
       DLOG(ERROR) << "Refusing to duplicate invalid handle.";
       continue;
     }
+    DCHECK_EQ(handles[i].owning_process, from_process);
     BOOL result = DuplicateHandle(
         from_process, handles[i].handle, to_process,
-        reinterpret_cast<HANDLE*>(handles + i), 0, FALSE,
+        &handles[i].handle, 0, FALSE,
         DUPLICATE_SAME_ACCESS | DUPLICATE_CLOSE_SOURCE);
-    if (!result)
+    if (result)
+      handles[i].owning_process = to_process;
+    else
       success = false;
   }
   return success;
 }
 #endif
 
 // Helper class for managing a Channel's read buffer allocations. This maintains
 // a single contiguous buffer with the layout:
 //
 //   [discarded bytes][occupied bytes][unoccupied bytes]
@@ skipping 192 matching lines @@
   return true;
 }
 
 void Channel::OnError() {
   if (delegate_)
     delegate_->OnChannelError();
 }
 
 }  // namespace edk
 }  // namespace mojo