Issue 191403002: Revert 255311 "Bind before sandbox lockdown on Windows."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 191403002: Revert 255311 "Bind before sandbox lockdown on Windows." (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 9 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 255311 "Bind before sandbox lockdown on Windows." Suspected as crasher. > Bind before sandbox lockdown on Windows. > Linux is unaffected. All changed code already is inside sandbox. > > BUG=348692 > > Review URL: https://codereview.chromium.org/185293014 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255685

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -41 lines)			Patch
M	trunk/src/chrome/utility/local_discovery/service_discovery_message_handler.cc	View	1 chunk	+17 lines, -13 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/net/dns/mock_mdns_socket_factory.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/net/udp/datagram_server_socket.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/net/udp/udp_server_socket.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/net/udp/udp_server_socket.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/net/udp/udp_socket_libevent.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/net/udp/udp_socket_libevent.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/net/udp/udp_socket_win.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/net/udp/udp_socket_win.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Buka (NO REVIEWS)

6 years, 9 months ago (2014-03-07 19:42:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r255685.