Issue 1914005: Call set_unblock(true) on async resize message to guarantee its...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1914005: Call set_unblock(true) on async resize message to guarantee its... (Closed)

Created:
10 years, 7 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
apatrick, jam, apatrick_chromium

CC:
chromium-reviews, jam+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Call set_unblock(true) on async resize message to guarantee its processing order relative to sync messages, in particular flush on behalf of SwapBuffers, in the GPU process. This fixes a race condition in WebGL initialization where the back buffer would sometimes not be resized properly. Thanks to jam for the suggestion for this fix. Tested manually by reloading the WebGL image-texture-test demo over 100 times and ensuring it displayed properly each time. BUG=42733 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46545

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	chrome/renderer/command_buffer_proxy.cc	View		1 chunk	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages