[Devtools] Fix to XMLView in Network Preview panel broken

[Devtools] Fix to XMLView in Network Preview panel broken

[Regression] Fixes bug where if XMLView is choosen for the preview
panel under network it will not display anything.

BUG=606953
R=lushnikov

Committed: https://crrev.com/c46ae245de2592511cd80628453d0da36172baec
Cr-Commit-Position: refs/heads/master@{#391016}

[allada, 2016-04-26 21:14:41]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[allada, 2016-04-26 21:14:58]

PTL

[commit-bot: I haz the power, 2016-04-26 21:15:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913993004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913993004/1

[lushnikov, 2016-04-26 21:34:02]

thanks, lgtm

It's unfortunate we lack a test for this though.

[commit-bot: I haz the power, 2016-04-26 22:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 22:37:21]

Dry run: This issue passed the CQ dry run.

[allada, 2016-04-26 23:13:56]

PTL

[allada, 2016-04-26 23:19:22]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 23:19:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913993004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913993004/20001

[commit-bot: I haz the power, 2016-04-27 00:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 00:24:15]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-04-28 05:41:42]

thanks, lgtm

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html
(right):

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:11:
var request = new
WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), 0,
'http://localhost');
InspectorTest.mainTarget

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:30:
return new Promise(function(done) {
you don't need this promise at all - just pass a callback in testPreviewer.

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:70:
function test6(next)
let's give some meaningful names to the functions - it will help to avoid having
four "test6" functions in future

[allada, 2016-05-02 17:59:24]

The CQ bit was checked by allada@chromium.org

[allada, 2016-05-02 17:59:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1913993004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-02 17:59:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913993004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913993004/40001

[allada, 2016-05-02 18:00:05]

DONE

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html
(right):

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:11:
var request = new
WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), 0,
'http://localhost');
On 2016/04/28 05:41:42, lushnikov wrote:
> InspectorTest.mainTarget

Done.

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:30:
return new Promise(function(done) {
On 2016/04/28 05:41:42, lushnikov wrote:
> you don't need this promise at all - just pass a callback in testPreviewer.

Done.

https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:70:
function test6(next)
On 2016/04/28 05:41:42, lushnikov wrote:
> let's give some meaningful names to the functions - it will help to avoid
having
> four "test6" functions in future

Done.

[commit-bot: I haz the power, 2016-05-02 19:02:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-02 19:04:43]

Description was changed from

==========
[Devtools] Fix to XMLView in Network Preview panel broken

[Regression] Fixes bug where if XMLView is choosen for the preview
panel under network it will not display anything.

BUG=606953
R=lushnikov
==========

to

==========
[Devtools] Fix to XMLView in Network Preview panel broken

[Regression] Fixes bug where if XMLView is choosen for the preview
panel under network it will not display anything.

BUG=606953
R=lushnikov

Committed: https://crrev.com/c46ae245de2592511cd80628453d0da36172baec
Cr-Commit-Position: refs/heads/master@{#391016}
==========

[commit-bot: I haz the power, 2016-05-02 19:04:44]

Patchset 3 (id:??) landed as
https://crrev.com/c46ae245de2592511cd80628453d0da36172baec
Cr-Commit-Position: refs/heads/master@{#391016}