Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1913993004: [Devtools] Fix to XMLView in Network Preview panel broken (Closed)

Created:
4 years, 8 months ago by allada
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fix to XMLView in Network Preview panel broken [Regression] Fixes bug where if XMLView is choosen for the preview panel under network it will not display anything. BUG=606953 R=lushnikov Committed: https://crrev.com/c46ae245de2592511cd80628453d0da36172baec Cr-Commit-Position: refs/heads/master@{#391016}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view-expected.txt View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
allada
PTL
4 years, 8 months ago (2016-04-26 21:14:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913993004/1
4 years, 8 months ago (2016-04-26 21:15:02 UTC) #3
lushnikov
thanks, lgtm It's unfortunate we lack a test for this though.
4 years, 8 months ago (2016-04-26 21:34:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 22:37:21 UTC) #6
allada
PTL
4 years, 8 months ago (2016-04-26 23:13:56 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913993004/20001
4 years, 8 months ago (2016-04-26 23:19:40 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 00:24:15 UTC) #11
lushnikov
thanks, lgtm https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html (right): https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html#newcode11 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:11: var request = new WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), 0, 'http://localhost'); ...
4 years, 7 months ago (2016-04-28 05:41:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913993004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913993004/40001
4 years, 7 months ago (2016-05-02 17:59:55 UTC) #15
allada
DONE https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html (right): https://codereview.chromium.org/1913993004/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html#newcode11 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-choose-preview-view.html:11: var request = new WebInspector.NetworkRequest(WebInspector.targetManager.mainTarget(), 0, 'http://localhost'); On ...
4 years, 7 months ago (2016-05-02 18:00:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 19:02:52 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 19:04:44 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c46ae245de2592511cd80628453d0da36172baec
Cr-Commit-Position: refs/heads/master@{#391016}

Powered by Google App Engine
This is Rietveld 408576698