Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

Issue 1913983002: Use document referrer policy when preloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test expectation Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/parser/HTMLPreloadScanner.h" 5 #include "core/html/parser/HTMLPreloadScanner.h"
6 6
7 #include "core/MediaTypeNames.h" 7 #include "core/MediaTypeNames.h"
8 #include "core/css/MediaValuesCached.h" 8 #include "core/css/MediaValuesCached.h"
9 #include "core/fetch/ClientHintsPreferences.h" 9 #include "core/fetch/ClientHintsPreferences.h"
10 #include "core/frame/Settings.h" 10 #include "core/frame/Settings.h"
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 data.monochromeBitsPerComponent = 0; 116 data.monochromeBitsPerComponent = 0;
117 data.primaryPointerType = PointerTypeFine; 117 data.primaryPointerType = PointerTypeFine;
118 data.defaultFontSize = 16; 118 data.defaultFontSize = 16;
119 data.threeDEnabled = true; 119 data.threeDEnabled = true;
120 data.mediaType = MediaTypeNames::screen; 120 data.mediaType = MediaTypeNames::screen;
121 data.strictMode = true; 121 data.strictMode = true;
122 data.displayMode = WebDisplayModeBrowser; 122 data.displayMode = WebDisplayModeBrowser;
123 return data; 123 return data;
124 } 124 }
125 125
126 void runSetUp(ViewportState viewportState, PreloadState preloadState = Prelo adEnabled) 126 void runSetUp(ViewportState viewportState, PreloadState preloadState = Prelo adEnabled, ReferrerPolicy documentReferrerPolicy = ReferrerPolicyDefault)
127 { 127 {
128 HTMLParserOptions options(&m_dummyPageHolder->document()); 128 HTMLParserOptions options(&m_dummyPageHolder->document());
129 KURL documentURL(ParsedURLString, "http://whatever.test/"); 129 KURL documentURL(ParsedURLString, "http://whatever.test/");
130 m_dummyPageHolder->document().settings()->setViewportEnabled(viewportSta te == ViewportEnabled); 130 m_dummyPageHolder->document().settings()->setViewportEnabled(viewportSta te == ViewportEnabled);
131 m_dummyPageHolder->document().settings()->setViewportMetaEnabled(viewpor tState == ViewportEnabled); 131 m_dummyPageHolder->document().settings()->setViewportMetaEnabled(viewpor tState == ViewportEnabled);
132 m_dummyPageHolder->document().settings()->setDoHtmlPreloadScanning(prelo adState == PreloadEnabled); 132 m_dummyPageHolder->document().settings()->setDoHtmlPreloadScanning(prelo adState == PreloadEnabled);
133 m_dummyPageHolder->document().setReferrerPolicy(documentReferrerPolicy);
133 m_scanner = HTMLPreloadScanner::create(options, documentURL, CachedDocum entParameters::create(&m_dummyPageHolder->document()), createMediaValuesData()); 134 m_scanner = HTMLPreloadScanner::create(options, documentURL, CachedDocum entParameters::create(&m_dummyPageHolder->document()), createMediaValuesData());
134 } 135 }
135 136
136 void SetUp() override 137 void SetUp() override
137 { 138 {
138 runSetUp(ViewportEnabled); 139 runSetUp(ViewportEnabled);
139 } 140 }
140 141
141 void test(TestCase testCase) 142 void test(TestCase testCase)
142 { 143 {
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 { "http://example.test", "<meta name='referrer' content='no-referrer'><i mg referrerpolicy='origin' src='bla.gif'/>", "bla.gif", "http://example.test/", Resource::Image, 0, ReferrerPolicyOrigin }, 356 { "http://example.test", "<meta name='referrer' content='no-referrer'><i mg referrerpolicy='origin' src='bla.gif'/>", "bla.gif", "http://example.test/", Resource::Image, 0, ReferrerPolicyOrigin },
356 // The scanner's state is not reset between test cases, so all subsequen t test cases have a document referrer policy of no-referrer. 357 // The scanner's state is not reset between test cases, so all subsequen t test cases have a document referrer policy of no-referrer.
357 { "http://example.test", "<img referrerpolicy='not-a-valid-policy' src=' bla.gif'/>", "bla.gif", "http://example.test/", Resource::Image, 0, ReferrerPoli cyNever }, 358 { "http://example.test", "<img referrerpolicy='not-a-valid-policy' src=' bla.gif'/>", "bla.gif", "http://example.test/", Resource::Image, 0, ReferrerPoli cyNever },
358 { "http://example.test", "<img src='bla.gif'/>", "bla.gif", "http://exam ple.test/", Resource::Image, 0, ReferrerPolicyNever } 359 { "http://example.test", "<img src='bla.gif'/>", "bla.gif", "http://exam ple.test/", Resource::Image, 0, ReferrerPolicyNever }
359 }; 360 };
360 361
361 for (const auto& testCase : testCases) 362 for (const auto& testCase : testCases)
362 test(testCase); 363 test(testCase);
363 } 364 }
364 365
366 // Tests that a document-level referrer policy (e.g. one set by HTTP
367 // header) is applied for preload requests.
368 TEST_F(HTMLPreloadScannerTest, testReferrerPolicyOnDocument)
369 {
370 runSetUp(ViewportEnabled, PreloadEnabled, ReferrerPolicyOrigin);
371 ReferrerPolicyTestCase testCases[] = {
372 { "http://example.test", "<img src='blah.gif'/>", "blah.gif", "http://ex ample.test/", Resource::Image, 0, ReferrerPolicyOrigin },
373 { "http://example.test", "<style>@import url('blah.css');</style>", "bla h.css", "http://example.test/", Resource::CSSStyleSheet, 0, ReferrerPolicyOrigin },
374 // Tests that a meta-delivered referrer policy with an
375 // unrecognized policy value does not override the document's
376 // referrer policy.
377 { "http://example.test", "<meta name='referrer' content='not-a-valid-pol icy'><img src='bla.gif'/>", "bla.gif", "http://example.test/", Resource::Image, 0, ReferrerPolicyOrigin },
378 // Tests that a meta-delivered referrer policy with a
379 // valid policy value does override the document's
380 // referrer policy.
381 { "http://example.test", "<meta name='referrer' content='unsafe-url'><im g src='bla.gif'/>", "bla.gif", "http://example.test/", Resource::Image, 0, Refer rerPolicyAlways },
382 };
383
384 for (const auto& testCase : testCases)
385 test(testCase);
386 }
387
365 TEST_F(HTMLPreloadScannerTest, testLinkRelPreload) 388 TEST_F(HTMLPreloadScannerTest, testLinkRelPreload)
366 { 389 {
367 TestCase testCases[] = { 390 TestCase testCases[] = {
368 {"http://example.test", "<link rel=preload href=bla>", "bla", "http://ex ample.test/", Resource::LinkPreload, 0}, 391 {"http://example.test", "<link rel=preload href=bla>", "bla", "http://ex ample.test/", Resource::LinkPreload, 0},
369 {"http://example.test", "<link rel=preload href=bla as=script>", "bla", "http://example.test/", Resource::Script, 0}, 392 {"http://example.test", "<link rel=preload href=bla as=script>", "bla", "http://example.test/", Resource::Script, 0},
370 {"http://example.test", "<link rel=preload href=bla as=style>", "bla", " http://example.test/", Resource::CSSStyleSheet, 0}, 393 {"http://example.test", "<link rel=preload href=bla as=style>", "bla", " http://example.test/", Resource::CSSStyleSheet, 0},
371 {"http://example.test", "<link rel=preload href=bla as=image>", "bla", " http://example.test/", Resource::Image, 0}, 394 {"http://example.test", "<link rel=preload href=bla as=image>", "bla", " http://example.test/", Resource::Image, 0},
372 {"http://example.test", "<link rel=preload href=bla as=font>", "bla", "h ttp://example.test/", Resource::Font, 0}, 395 {"http://example.test", "<link rel=preload href=bla as=font>", "bla", "h ttp://example.test/", Resource::Font, 0},
373 {"http://example.test", "<link rel=preload href=bla as=media>", "bla", " http://example.test/", Resource::Media, 0}, 396 {"http://example.test", "<link rel=preload href=bla as=media>", "bla", " http://example.test/", Resource::Media, 0},
374 {"http://example.test", "<link rel=preload href=bla as=track>", "bla", " http://example.test/", Resource::TextTrack, 0}, 397 {"http://example.test", "<link rel=preload href=bla as=track>", "bla", " http://example.test/", Resource::TextTrack, 0},
375 }; 398 };
376 399
377 for (const auto& testCase : testCases) 400 for (const auto& testCase : testCases)
378 test(testCase); 401 test(testCase);
379 } 402 }
380 403
381 } // namespace blink 404 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698