Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1913973004:
Include file names in hydrogen logs (Closed)
|
Created:
4 years, 8 months ago by mattloring Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionInclude file names in hydrogen logs
Hydrogen logs are ambiguous if multiple functions share the same name.
This change adds file names to this output. Functions are now named
<file_name>:<function_name> to reduce this ambiguity.
R=ofrobots@google.com
BUG=
Committed: https://crrev.com/058809a6914f4a85932d2fad73c80451fc0aab0e
Cr-Commit-Position: refs/heads/master@{#36076}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : validate script name before casing #Patch Set 4 : rebase #Patch Set 5 : Fix optimization id collection #Messages
Total messages: 34 (16 generated)
Description was changed from ========== Include file names in hydrogen logs Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= ========== to ========== Include file names in hydrogen logs Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= ==========
mattloring@google.com changed reviewers: + jkummerow@chromium.org, jochen@chromium.org
lgtm
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...) v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_nodcheck_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...) v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1163) v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
This needs another look. Added a fix for failing tests.
lgtm
The CQ bit was checked by mattloring@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5375) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5356) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14763)
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5366) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5376) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5357) v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1252) v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/6908)
The CQ bit was checked by mattloring@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mattloring@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/1913973004/#ps80001 (title: "Fix optimization id collection")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973004/80001
Message was sent while issue was closed.
Description was changed from ========== Include file names in hydrogen logs Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= ========== to ========== Include file names in hydrogen logs Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Include file names in hydrogen logs Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= ========== to ========== Include file names in hydrogen logs Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= Committed: https://crrev.com/058809a6914f4a85932d2fad73c80451fc0aab0e Cr-Commit-Position: refs/heads/master@{#36076} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/058809a6914f4a85932d2fad73c80451fc0aab0e Cr-Commit-Position: refs/heads/master@{#36076} |
