Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1913973003: [chromecast] Simplify CastAudioOutputStream. (Closed)

Created:
4 years, 8 months ago by alokp
Modified:
4 years, 8 months ago
Reviewers:
halliwell
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, jam, halliwell+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Simplify CastAudioOutputStream. https://codereview.chromium.org/1908423006/ makes CastAudioManager run on CMA thread. Now there is no need to post tasks when using CMA backend in CastAudioAoutputStream. BUG=594234 Committed: https://crrev.com/a1ad299432ea0245cf747dbe5e7927c6aed1e7f5 Cr-Commit-Position: refs/heads/master@{#389813}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -282 lines) Patch
M chromecast/media/audio/cast_audio_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream.cc View 13 chunks +60 lines, -129 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 2 19 chunks +52 lines, -143 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alokp
4 years, 8 months ago (2016-04-26 00:35:35 UTC) #4
halliwell
On 2016/04/26 00:35:35, alokp wrote: Love the cleanup! :) lgtm
4 years, 8 months ago (2016-04-26 03:00:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913973003/40001
4 years, 8 months ago (2016-04-26 16:44:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 17:19:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 17:20:57 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a1ad299432ea0245cf747dbe5e7927c6aed1e7f5
Cr-Commit-Position: refs/heads/master@{#389813}

Powered by Google App Engine
This is Rietveld 408576698