chrome/BUILD.gn - Issue 1913943003: Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1913943003: Remove dependencies on chrome\installer from the ChromeCrashReporterClient class on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 7828eb1492df3361573bbee4d77eabdcaa6bd73b..f3432cb2d50281e8a7ef6a1ac445fbac95ec35d9 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -136,6 +136,7 @@ if (!is_android) {

"//chrome/chrome_watcher:client",

"//chrome/common:constants",

"//chrome/common:metrics_constants_util_win",

+ "//chrome/install_static:install_static_util",

"//chrome/installer/util:with_no_strings",

"//chrome_elf",

"//components/browser_watcher:browser_watcher_client",

@@ -314,6 +315,7 @@ if (is_mac || is_win) {

":chrome_dll_version",

"//base/trace_event/etw_manifest:chrome_events_win",

"//chrome/app/theme:chrome_unscaled_resources",

+ "//chrome/install_static:install_static_util",

"//chrome_elf",

"//components/crash/content/app",

"//components/policy",

« no previous file with comments | « no previous file | chrome/app/DEPS » ('j') | chrome/install_static/install_util.h » ('J')