gerrit_util.py - Issue 1913913002: GetChangeDescriptionFromGitiles followup: future todo for no gitiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gerrit_util.py

Issue 1913913002: GetChangeDescriptionFromGitiles followup: future todo for no gitiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gerrit_util.py

diff --git a/gerrit_util.py b/gerrit_util.py

index 049c1c28926df10fa74fb8ed7a81ec5d78e82ebc..78238396f4b7323dfe1ff43089aa4a873fdd80e6 100755

--- a/gerrit_util.py

+++ b/gerrit_util.py

@@ -491,6 +491,10 @@ def GetChangeDescriptionFromGitiles(url, revision):

"""

parsed = urlparse.urlparse(url)

path = '%s/+/%s?format=json' % (parsed.path, revision)

+ # Note: Gerrit isntances that chrome infrastructure uses thus far have all

Bons 2016/04/25 20:06:25 s/isntances/instances Also, you have Gerrit and G

tandrii(chromium) 2016/04/26 14:26:12 Done.

+ # enabled Gitiles, which allowes us to execute this call. This isn't true for

+ # all Gerrit instances out there. Thus, if line below fails, consider adding a

+ # fallback onto actually fetching ref from remote using pure git.

return ReadHttpJsonResponse(CreateHttpConn(parsed.netloc, path))['message']

« no previous file with comments | « no previous file | no next file » | no next file with comments »