third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1913843004: Implementing document.setRootScroller API for main thread scrolling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1913843004: Implementing document.setRootScroller API for main thread scrolling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@overscrollController

Patch Set: Rebase and remove whitespace in Document.idl Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Document.idl ('K') | « third_party/WebKit/Source/core/frame/FrameHost.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/RootScroller.h » ('j') | third_party/WebKit/Source/core/page/scrolling/RootScroller.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index d212e6c7d4057c758c0b086fb52b523cf1b457a8..8d6712b0d366444f0acf43315e0a0996b788db8c 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -2505,10 +2505,7 @@ bool EventHandler::isRootScroller(const Node& node) const

if (!node.isElementNode() || node.document().ownerElement())

return false;

- Element* scrollingElement = node.document().scrollingElement();

- return scrollingElement

- ? toElement(&node) == node.document().scrollingElement()

- : toElement(&node) == node.document().documentElement();

+ return node.document().rootScroller() == toElement(&node);

}

WebInputEventResult EventHandler::handleGestureScrollUpdate(const PlatformGestureEvent& gestureEvent)