android: Fix build more after 255971.

android: Fix build more after 255971.

Two more ant scripts were implicitly depending on the generated
manifest file via an implicit dependency through a stamp file.
Follow-up to https://codereview.chromium.org/193163004

BUG=256020
R=cjhopman@chromium.org
TBR=cjhopman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256038

[cjhopman, 2014-03-10 21:34:41]

Sorry, I should have caught this before. To make up for missing it I did this:
https://codereview.chromium.org/193283002/ :)

You can ignore my random comments on other lines of these ant files if you want.

This lgtm. Ideally all these little hidden dependencies would be reflected in
the gyp files like you've done here.

https://codereview.chromium.org/191383008/diff/1/build/android/ant/apk-obfusc...
File build/android/ant/apk-obfuscate.xml (right):

https://codereview.chromium.org/191383008/diff/1/build/android/ant/apk-obfusc...
build/android/ant/apk-obfuscate.xml:22: <property name="out.dir" value="bin" />
This is awkward. This line doesn't do anything (and would be wrong if it did).

https://codereview.chromium.org/191383008/diff/1/build/android/ant/apk-obfusc...
build/android/ant/apk-obfuscate.xml:23: <property name="out.absolute.dir"
location="${out.dir}" />
I'm pretty sure out.dir is actually already absolute because it uses location
instead of value above

[Nico, 2014-03-10 21:36:57]

Committed patchset #1 manually as r256038 (presubmit successful).

[Nico, 2014-03-10 21:38:24]

Thanks! You++ for the https://codereview.chromium.org/193283002/ :-)

https://codereview.chromium.org/191383008/diff/1/build/android/ant/apk-obfusc...
File build/android/ant/apk-obfuscate.xml (right):

https://codereview.chromium.org/191383008/diff/1/build/android/ant/apk-obfusc...
build/android/ant/apk-obfuscate.xml:23: <property name="out.absolute.dir"
location="${out.dir}" />
On 2014/03/10 21:34:41, cjhopman wrote:
> I'm pretty sure out.dir is actually already absolute because it uses location
> instead of value above

Yes, all the xml files have several abs.foo and foo properties that look
somewhat redundant. Should probably be cleaned up at some point.