Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/perf/metrics/loading.py

Issue 191383003: First cut of chrome-proxy (data reduction proxy) measurements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/loading.py
diff --git a/tools/perf/metrics/loading.py b/tools/perf/metrics/loading.py
index c1d4360f31e77932527259f70602bae048438935..c2ed1767262b6957aff8eb56676c9f8f386415b9 100644
--- a/tools/perf/metrics/loading.py
+++ b/tools/perf/metrics/loading.py
@@ -15,12 +15,40 @@ class LoadingMetric(Metric):
def AddResults(self, tab, results):
load_timings = tab.EvaluateJavaScript('window.performance.timing')
- load_time_ms = (
- float(load_timings['loadEventStart']) -
- load_timings['navigationStart'])
- dom_content_loaded_time_ms = (
+
+ # All numbers in milliseconds.
tonyg 2014/03/25 16:12:25 Let's factor just this file out into a separate pa
bolian 2014/03/25 18:19:01 Done. Np at all, that is good. Split out: https://
+ page_load = (
+ float(load_timings['loadEventStart']) - load_timings['navigationStart'])
+ results.Add('page_load', 'ms', page_load)
tonyg 2014/03/25 16:12:25 Naming convention suggestion: # NavigationStart r
bolian 2014/03/25 18:19:01 Doen. much better.
+
+ dom_content_loaded = (
float(load_timings['domContentLoadedEventStart']) -
load_timings['navigationStart'])
- results.Add('load_time', 'ms', load_time_ms)
- results.Add('dom_content_loaded_time', 'ms',
- dom_content_loaded_time_ms)
+ results.Add('dom_content_loaded', 'ms', dom_content_loaded)
+
+ delay_before_fetch = (
+ float(load_timings['fetchStart']) - load_timings['navigationStart'])
+ results.Add('delay_before_fetch', 'ms', delay_before_fetch,
+ data_type='unimportant')
+
+ delay_before_request = (
+ float(load_timings['requestStart']) - load_timings['navigationStart'])
+ results.Add('delay_before_request', 'ms', delay_before_request,
+ data_type='unimportant')
+
+ domain_lookup = (
+ float(load_timings['domainLookupEnd']) -
+ load_timings['domainLookupStart'])
+ results.Add('domain_lookup', 'ms', domain_lookup, data_type='unimportant')
+
+ connect = (
+ float(load_timings['connectEnd']) - load_timings['connectStart'])
+ results.Add('connect', 'ms', connect, data_type='unimportant')
+
+ request = (
+ float(load_timings['responseStart']) - load_timings['requestStart'])
+ results.Add('request', 'ms', request, data_type='unimportant')
+
+ response = (
+ float(load_timings['responseEnd']) - load_timings['responseStart'])
+ results.Add('response', 'ms', response, data_type='unimportant')

Powered by Google App Engine
This is Rietveld 408576698