Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: tools/telemetry/telemetry/page/actions/navigate.py

Issue 191383003: First cut of chrome-proxy (data reduction proxy) measurements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/navigate.py
diff --git a/tools/telemetry/telemetry/page/actions/navigate.py b/tools/telemetry/telemetry/page/actions/navigate.py
index 655d088296fb229272b1f6f07341d629321262a6..9e783a76fe656691e55be3d75e4dfced04f6bf32 100644
--- a/tools/telemetry/telemetry/page/actions/navigate.py
+++ b/tools/telemetry/telemetry/page/actions/navigate.py
@@ -14,5 +14,10 @@ class NavigateAction(page_action.PageAction):
else:
target_side_url = page.url
- tab.Navigate(target_side_url, page.script_to_evaluate_on_commit)
+ if hasattr(self, 'timeout_seconds') and self.timeout_seconds:
tonyg 2014/03/12 02:08:37 Please break this out to a new CL and mail to dtu.
bolian 2014/03/19 00:20:03 Split out as https://codereview.chromium.org/20248
+ tab.Navigate(target_side_url,
+ page.script_to_evaluate_on_commit,
+ self.timeout_seconds)
+ else:
+ tab.Navigate(target_side_url, page.script_to_evaluate_on_commit)
tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()

Powered by Google App Engine
This is Rietveld 408576698