Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1913813004:
Update SK_IMAGE_VERSION, run nanobench on its own image set (Closed)
DescriptionUpdate SK_IMAGE_VERSION, run nanobench on its own image set
I've added a new directory to the cloud
(gs://chromium-skia-gm/skimage/v4/nanobench) which will
allow us to run dm and nanobench on different sets of
images.
The dm image set will stay the same, and includes
incomplete images, edge cases images, etc.
The nanobench set is much smaller, and includes jpegs and
pngs that we've found useful to bench in the past, plus
a couple of each for the other formats. We can refine
this set as we move forward (and may also want to monitor
these images on perf.skia.org).
For now the goal is to reduce nanobench runtime by not
testing on many, many obscure images that are not
particularly interesting to time.
The actual change to use nanobench images is in:
https://codereview.chromium.org/1917903003/
BUG=skia:5181
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913813004
Committed: https://skia.googlesource.com/skia/+/0b55664afc854b03082c467505b1a811721bcd7a
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== Update SK_IMAGE_VERSION, run nanobench on its own image set BUG=skia: ========== to ========== Update SK_IMAGE_VERSION, run nanobench on its own image set BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Update SK_IMAGE_VERSION, run nanobench on its own image set BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update SK_IMAGE_VERSION, run nanobench on its own image set I've added a new directory to the cloud (gs://chromium-skia-gm/skimage/v4/nanobench) which will allow us to run dm and nanobench on different sets of images. The dm image set will stay the same, and includes incomplete images, edge cases images, etc. The nanobench set is much smaller, and includes jpegs and pngs that we've found useful to bench in the past, plus a couple of each for the other formats. We can refine this set as we move forward (and may also want to monitor these images on perf.skia.org). For now the goal is to reduce nanobench runtime by not testing on many, many obscure images that are not particularly interesting to time. BUG=skia:5181 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Update SK_IMAGE_VERSION, run nanobench on its own image set I've added a new directory to the cloud (gs://chromium-skia-gm/skimage/v4/nanobench) which will allow us to run dm and nanobench on different sets of images. The dm image set will stay the same, and includes incomplete images, edge cases images, etc. The nanobench set is much smaller, and includes jpegs and pngs that we've found useful to bench in the past, plus a couple of each for the other formats. We can refine this set as we move forward (and may also want to monitor these images on perf.skia.org). For now the goal is to reduce nanobench runtime by not testing on many, many obscure images that are not particularly interesting to time. BUG=skia:5181 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update SK_IMAGE_VERSION, run nanobench on its own image set I've added a new directory to the cloud (gs://chromium-skia-gm/skimage/v4/nanobench) which will allow us to run dm and nanobench on different sets of images. The dm image set will stay the same, and includes incomplete images, edge cases images, etc. The nanobench set is much smaller, and includes jpegs and pngs that we've found useful to bench in the past, plus a couple of each for the other formats. We can refine this set as we move forward (and may also want to monitor these images on perf.skia.org). For now the goal is to reduce nanobench runtime by not testing on many, many obscure images that are not particularly interesting to time. The actual change to use nanobench images is in: https://codereview.chromium.org/1917903003/ BUG=skia:5181 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
msarett@google.com changed reviewers: + borenet@google.com, scroggo@google.com
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913813004/1
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913813004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913813004/1
Message was sent while issue was closed.
Description was changed from ========== Update SK_IMAGE_VERSION, run nanobench on its own image set I've added a new directory to the cloud (gs://chromium-skia-gm/skimage/v4/nanobench) which will allow us to run dm and nanobench on different sets of images. The dm image set will stay the same, and includes incomplete images, edge cases images, etc. The nanobench set is much smaller, and includes jpegs and pngs that we've found useful to bench in the past, plus a couple of each for the other formats. We can refine this set as we move forward (and may also want to monitor these images on perf.skia.org). For now the goal is to reduce nanobench runtime by not testing on many, many obscure images that are not particularly interesting to time. The actual change to use nanobench images is in: https://codereview.chromium.org/1917903003/ BUG=skia:5181 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update SK_IMAGE_VERSION, run nanobench on its own image set I've added a new directory to the cloud (gs://chromium-skia-gm/skimage/v4/nanobench) which will allow us to run dm and nanobench on different sets of images. The dm image set will stay the same, and includes incomplete images, edge cases images, etc. The nanobench set is much smaller, and includes jpegs and pngs that we've found useful to bench in the past, plus a couple of each for the other formats. We can refine this set as we move forward (and may also want to monitor these images on perf.skia.org). For now the goal is to reduce nanobench runtime by not testing on many, many obscure images that are not particularly interesting to time. The actual change to use nanobench images is in: https://codereview.chromium.org/1917903003/ BUG=skia:5181 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/0b55664afc854b03082c467505b1a811721bcd7a ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0b55664afc854b03082c467505b1a811721bcd7a |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
