Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1913813003: [js-perf-test] Add microbenchmarks for in operator and Object.prototype.hasOwnProperty(). (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-test] Add microbenchmarks for in operator and Object.prototype.hasOwnProperty(). BUG=v8:2472, v8:2743 LOG=N Committed: https://crrev.com/5796ae9de4ceca002a5fab1c07afccffb6ba3939 Cr-Commit-Position: refs/heads/master@{#35789}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -6 lines) Patch
M test/js-perf-test/JSTests.json View 1 chunk +65 lines, -0 lines 0 comments Download
A test/js-perf-test/PropertyQueries/PropertyQueries.json View 1 chunk +80 lines, -0 lines 0 comments Download
A test/js-perf-test/PropertyQueries/property-queries.js View 1 1 chunk +260 lines, -0 lines 0 comments Download
A + test/js-perf-test/PropertyQueries/run.js View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Igor Sheludko
PTAL. I guess it would be interesting to know how fast are we for every ...
4 years, 8 months ago (2016-04-25 18:45:04 UTC) #4
Toon Verwaest
lgtm https://codereview.chromium.org/1913813003/diff/40001/test/js-perf-test/PropertyQueries/property-queries.js File test/js-perf-test/PropertyQueries/property-queries.js (right): https://codereview.chromium.org/1913813003/diff/40001/test/js-perf-test/PropertyQueries/property-queries.js#newcode77 test/js-perf-test/PropertyQueries/property-queries.js:77: return Object.keys(o)[0]; Object.keys({[s]:0})[0] :)
4 years, 8 months ago (2016-04-26 08:11:49 UTC) #5
Igor Sheludko
https://codereview.chromium.org/1913813003/diff/40001/test/js-perf-test/PropertyQueries/property-queries.js File test/js-perf-test/PropertyQueries/property-queries.js (right): https://codereview.chromium.org/1913813003/diff/40001/test/js-perf-test/PropertyQueries/property-queries.js#newcode77 test/js-perf-test/PropertyQueries/property-queries.js:77: return Object.keys(o)[0]; On 2016/04/26 08:11:48, Toon Verwaest wrote: > ...
4 years, 8 months ago (2016-04-26 09:59:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913813003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913813003/60001
4 years, 8 months ago (2016-04-26 09:59:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 8 months ago (2016-04-26 10:21:59 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 10:24:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5796ae9de4ceca002a5fab1c07afccffb6ba3939
Cr-Commit-Position: refs/heads/master@{#35789}

Powered by Google App Engine
This is Rietveld 408576698