Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1913813002: command_buffer: Check draw FBO for path rendering draw functions (Closed)

Created:
4 years, 7 months ago by Kimmo Kinnunen
Modified:
4 years, 7 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lazy-bindframebuffer-01-remove-glbegin-glend-workaround
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command_buffer: Check draw FBO for path rendering draw functions Check draw FBO validity for path rendering draw functions. All other draw functions call the method too. BUG=603407 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a7238d6dd542777f652a6ebd223a744c52e94e83 Cr-Commit-Position: refs/heads/master@{#389757}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -14 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 24 chunks +52 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Kimmo Kinnunen
4 years, 7 months ago (2016-04-25 13:08:14 UTC) #3
Zhenyao Mo
On 2016/04/25 13:08:14, Kimmo Kinnunen wrote: lgtm
4 years, 7 months ago (2016-04-25 20:23:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913813002/20001
4 years, 7 months ago (2016-04-26 11:10:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-26 12:42:53 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 12:43:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7238d6dd542777f652a6ebd223a744c52e94e83
Cr-Commit-Position: refs/heads/master@{#389757}

Powered by Google App Engine
This is Rietveld 408576698