Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 191373002: Move Googlers to gs:// based toolchain pull (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Move Googlers to gs:// based toolchain pull The gs:// download path is much faster. Move anyone who could have access to gs://chrome-wintoolchain/ over to that for less pain. The downside is that we have to prompt them to run download_from_google_storage --config which people are going to complain about, but I think this is a better experience overall. R=iannucci@chromium.org,hinoka@chromium.org BUG=349964 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255696

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -10 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 1 4 chunks +54 lines, -4 lines 0 comments Download
M win_toolchain/toolchain2013.py View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 9 months ago (2014-03-07 19:27:01 UTC) #1
iannucci
lgtm https://codereview.chromium.org/191373002/diff/1/win_toolchain/get_toolchain_if_necessary.py File win_toolchain/get_toolchain_if_necessary.py (right): https://codereview.chromium.org/191373002/diff/1/win_toolchain/get_toolchain_if_necessary.py#newcode169 win_toolchain/get_toolchain_if_necessary.py:169: # gclient's buffering make this hang if we're ...
6 years, 9 months ago (2014-03-07 20:10:19 UTC) #2
scottmg
On 2014/03/07 20:10:19, iannucci wrote: > lgtm > > https://codereview.chromium.org/191373002/diff/1/win_toolchain/get_toolchain_if_necessary.py > File win_toolchain/get_toolchain_if_necessary.py (right): > ...
6 years, 9 months ago (2014-03-07 20:12:31 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 9 months ago (2014-03-07 20:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/191373002/20001
6 years, 9 months ago (2014-03-07 20:12:56 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 20:17:56 UTC) #6
Message was sent while issue was closed.
Change committed as 255696

Powered by Google App Engine
This is Rietveld 408576698