Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1913693002: Histogram the amount of time spent on HTTP(S) page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index c5705732f61144dcebb8424f6531183a7ea0638a..afa030ded70aec9461b5307eff0c383e0e20336d 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -301,6 +301,9 @@ void PageLoadTracker::WebContentsHidden() {
DCHECK_EQ(started_in_foreground_, foreground_time_.is_null());
background_time_ = base::TimeTicks::Now();
}
+
+ for (const auto& observer : observers_)
+ observer->OnHidden();
}
void PageLoadTracker::WebContentsShown() {
@@ -312,6 +315,9 @@ void PageLoadTracker::WebContentsShown() {
DCHECK_NE(started_in_foreground_, background_time_.is_null());
foreground_time_ = base::TimeTicks::Now();
}
+
+ for (const auto& observer : observers_)
+ observer->OnShown();
}
void PageLoadTracker::Commit(content::NavigationHandle* navigation_handle) {
@@ -320,7 +326,7 @@ void PageLoadTracker::Commit(content::NavigationHandle* navigation_handle) {
commit_time_ = base::TimeTicks::Now();
url_ = navigation_handle->GetURL();
for (const auto& observer : observers_) {
- observer->OnCommit(navigation_handle);
+ observer->OnCommit(navigation_handle, started_in_foreground_);
}
LogAbortChainHistograms(navigation_handle);
}

Powered by Google App Engine
This is Rietveld 408576698