chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h - Issue 1913693002: Histogram the amount of time spent on HTTP(S) page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 1913693002: Histogram the amount of time spent on HTTP(S) page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/https_page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

index 429bd90fd845e0ebc05f3e82dcc3453d9a539848..b805aafd38cf7e548ef6b0df25a4ffd92eac965b 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

@@ -84,7 +84,8 @@ class FromGWSPageLoadMetricsObserver

// page_load_metrics::PageLoadMetricsObserver implementation:

void OnStart(content::NavigationHandle* navigation_handle,

const GURL& currently_committed_url) override;

- void OnCommit(content::NavigationHandle* navigation_handle) override;

+ void OnCommit(content::NavigationHandle* navigation_handle,

+ bool started_in_foreground) override;

void OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;