Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java

Issue 1913673002: Close IME on tapping on Blimp web content pane (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
index 212d15db17a1b7d194ef1ba018f79d0cd08b9da8..27d6a44ad8044f4fb403fdf36870726eeaaa1a5e 100644
--- a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
+++ b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
@@ -16,6 +16,7 @@ import android.view.WindowManager;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.blimp.session.BlimpClientSession;
+import org.chromium.ui.UiUtils;
/**
* A {@link View} that will visually represent the Blimp rendered content. This {@link View} starts
@@ -96,6 +97,10 @@ public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
int eventAction = event.getActionMasked();
+ // Close the IME. It might be open for typing URL into toolbar.
+ // TODO(shaktisahu): Detect if the IME was open and return immediately (crbug/606977)
+ UiUtils.hideKeyboard(this);
+
if (!isValidTouchEventActionForNative(eventAction)) return false;
int pointerCount = event.getPointerCount();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698