vm: Generate 'and' instruction for Smi values.

vm: Generate 'and' instruction for Smi values.

This pattern ensures the generation of 'and' instructions on the Smi x Smi path of a polymorphic & operation.

There are two 'and' operations on most simple _InternalLinkedHashMap and _CompactLinkedHashSet operations. One of the inputs, the hashCode, is occasionally a _Bigint.  This change ensures that the usual case path has an 'and' instruction instead of a call to _IntegerImplementation.&

R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/38fdb4bd4aa6b1cb2176640cbfe30e2757f45760

[sra1, 2016-04-23 01:01:13]

Patchset #1 (id:1) has been deleted

[sra1, 2016-04-23 01:05:13]

Description was changed from

==========
vm: Generate 'and' instruction for Smi values.
==========

to

==========
vm: Generate 'and' instruction for Smi values.

This pattern ensures the generation of 'and' instructions on the Smi x Smi path
of a polymorphic & operation.
==========

[sra1, 2016-04-29 01:20:26]

Description was changed from

==========
vm: Generate 'and' instruction for Smi values.

This pattern ensures the generation of 'and' instructions on the Smi x Smi path
of a polymorphic & operation.
==========

to

==========
vm: Generate 'and' instruction for Smi values.

This pattern ensures the generation of 'and' instructions on the Smi x Smi path
of a polymorphic & operation.

There are two 'and' operations on most simple _InternalLinkedHashMap and
_CompactLinkedHashSet operations. One of the inputs, the hashCode, is
occasionally a _Bigint.  This change ensures that the usual case path has an
'and' instruction instead of a call to _IntegerImplementation.&
==========

[sra1, 2016-04-29 01:20:26]

sra@google.com changed reviewers:
+ regis@google.com

[regis, 2016-04-29 16:37:14]

LGTM

[srdjan, 2016-04-29 17:35:30]

srdjan@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-04-29 17:35:31]

DBC

https://chromiumcodereview.appspot.com/1913663002/diff/20001/runtime/lib/inte...
File runtime/lib/integers.cc (right):

https://chromiumcodereview.appspot.com/1913663002/diff/20001/runtime/lib/inte...
runtime/lib/integers.cc:298: left.ToCString(), right.ToCString());
Please use THR_Print instead

[sra1, 2016-07-04 23:28:09]

Description was changed from

==========
vm: Generate 'and' instruction for Smi values.

This pattern ensures the generation of 'and' instructions on the Smi x Smi path
of a polymorphic & operation.

There are two 'and' operations on most simple _InternalLinkedHashMap and
_CompactLinkedHashSet operations. One of the inputs, the hashCode, is
occasionally a _Bigint.  This change ensures that the usual case path has an
'and' instruction instead of a call to _IntegerImplementation.&
==========

to

==========
vm: Generate 'and' instruction for Smi values.

This pattern ensures the generation of 'and' instructions on the Smi x Smi path
of a polymorphic & operation.

There are two 'and' operations on most simple _InternalLinkedHashMap and
_CompactLinkedHashSet operations. One of the inputs, the hashCode, is
occasionally a _Bigint.  This change ensures that the usual case path has an
'and' instruction instead of a call to _IntegerImplementation.&

R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/38fdb4bd4aa6b1cb2176640cbfe30e2757f45760
==========

[sra1, 2016-07-04 23:28:11]

Committed patchset #2 (id:40001) manually as
38fdb4bd4aa6b1cb2176640cbfe30e2757f45760 (presubmit successful).