Enable emma code coverage for JUnit testcases.

build/android/gyp/create_java_binary_script.py

 #!/usr/bin/env python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Creates a simple script to run a java "binary".
 
 This creates a script that sets up the java command line for running a java
 jar. This includes correctly setting the classpath and the main class.
@@ skipping 19 matching lines @@
 
 self_dir = os.path.dirname(__file__)
 classpath = [{classpath}]
 bootclasspath = [{bootclasspath}]
 extra_program_args = {extra_program_args}
 if os.getcwd() != self_dir:
   offset = os.path.relpath(self_dir, os.getcwd())
   classpath = [os.path.join(offset, p) for p in classpath]
   bootclasspath = [os.path.join(offset, p) for p in bootclasspath]
 java_cmd = ["java"]
+java_cmd.append("-noverify")

[BigBossZhiling, 2016/04/22 21:37:02]

Otherwise emma will run into a werid error.

 if bootclasspath:
     java_cmd.append("-Xbootclasspath/p:" + ":".join(bootclasspath))
 java_cmd.extend(
     ["-classpath", ":".join(classpath), "-enableassertions", \"{main_class}\"])
 java_cmd.extend(extra_program_args)
 java_cmd.extend(sys.argv[1:])
 os.execvp("java", java_cmd)
 """
 
 def main(argv):
   argv = build_utils.ExpandFileArgs(argv)
   parser = optparse.OptionParser()
   build_utils.AddDepfileOption(parser)
   parser.add_option('--output', help='Output path for executable script.')
   parser.add_option('--jar-path', help='Path to the main jar.')
   parser.add_option('--main-class',
       help='Name of the java class with the "main" entry point.')
   parser.add_option('--classpath', action='append', default=[],
       help='Classpath for running the jar.')
   parser.add_option('--bootclasspath', action='append', default=[],
       help='zip/jar files to add to bootclasspath for java cmd.')
   options, extra_program_args = parser.parse_args(argv)
 
   classpath = [options.jar_path]
   for cp_arg in options.classpath:
     classpath += build_utils.ParseGypList(cp_arg)
+  classpath += \
+    ['../../third_party/android_tools_internal/sdk/tools/lib/emma.jar']

[BigBossZhiling, 2016/04/22 21:37:02]

After talking to Andrew, he said that since I don't need it during compilation,
I might be able to just hard-code this here.

[jbudorick, 2016/04/22 21:38:24]

I don't think we should be adding this unconditionally to the classpath. Can we
do so only if coverage is enabled?

(Also, this path should be third_party/android_tools/sdk/tools/lib/emma.jar)

[mikecase (-- gone --), 2016/04/22 23:51:45]

Do you need this in the classpath when running the test? If you do, you should
modify the deps variable in GN when building jars with emma enabled. I didn't
think you needed this in the classpath for tests though, I thought it was just
to process the files emma generates.

This script will process the generated emma files.
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gene...

[BigBossZhiling, 2016/04/23 01:00:55]

Yes, we need this classpath when we run the test, otherwise it will fail.

We don't need this file in the process of compilation, we only need this file
when we run the test (specifically this script). And we never build this file,
it is always there in the 3rd party directory.

I searched for gn files that call this create java binary script, and the owner
of the file actually suggested me hard code the classpath here if I don't need
the jar file for compilation, but just for this script. However I do agree that
this is not the best place to add the classpath, given that this is the only
explicit class path in the whole script. lol. So please point me to how to add
it. Or I can ask Andrew again and tell him that its ok to bundle the jar file
for compilation too so that we will have a more systematic way of adding
dependencies. Thoughts?

Thanks for sharing the link!

On 2016/04/22 23:51:45, mikecase wrote:

[BigBossZhiling, 2016/04/26 00:01:46]

I took away my change and tried to run junit tests with gyp, but it still fails.
Is it true that junit tests just don't work with gyp?

[agrieve, 2016/04/26 00:08:01]

I meant to hardcode it in the .gni file here:
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/andro...

E.g.
if (emma_coverage) {
  args += ["--classpath", rebase_path(emma_path, root_out_dir)]
}

Probably also want to create a separate flag for -noverify and pass that only
when emma_coverage is set.


I wouldn't bother getting this to work for GYP. GYP will hopefully by gone by
the end of the week.

 
   bootclasspath = []
   for bootcp_arg in options.bootclasspath:
     bootclasspath += build_utils.ParseGypList(bootcp_arg)
 
   run_dir = os.path.dirname(options.output)
   bootclasspath = [os.path.relpath(p, run_dir) for p in bootclasspath]
   classpath = [os.path.relpath(p, run_dir) for p in classpath]

[mikecase (-- gone --), 2016/04/25 18:36:40]

I dont think hard coding the path will work. It makes the path relative to the
output script here, and like I dont think something like...

os.path.relpath('../../third_party/android_tools_internal/sdk/tools/lib/emma.jar',
'/usr/local/..../src/out/Debug/bin')

will be what you want. And since GN and GYP run differently, I don't think you
can get it to work on both by hardcoding it. Have you tested it on both. I could
be wrong, but be sure to test it on both and look at the generated script to
check taht the path is correct on both.

 
   with open(options.output, 'w') as script:
     script.write(script_template.format(
       classpath=('"%s"' % '", "'.join(classpath)),
       bootclasspath=('"%s"' % '", "'.join(bootclasspath)
                      if bootclasspath else ''),
       main_class=options.main_class,
       extra_program_args=repr(extra_program_args)))
 
   os.chmod(options.output, 0750)
 
   if options.depfile:
     build_utils.WriteDepfile(
         options.depfile,
         build_utils.GetPythonDependencies())
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))