Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1913453002: ColumnBalancer: Don't leak the break-after value from the previous sibling to children. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ColumnBalancer: Don't leak the break-after value from the previous sibling to children. The break-after value of an object should only be considered and joined with the break-before value of the next in-flow sibling. Said sibling should not let its children see this value, or anything like that. Doing that might trick the balancer into believing that we have more forced breaks than what we actually have. So there's no point in storing this state as a member in ColumnBalancer. Keep it local to each object instead. BUG=605902 Committed: https://crrev.com/f9ae8afc886232819001f274825a6c55d7fc8482 Cr-Commit-Position: refs/heads/master@{#389144}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-22 15:13:06 UTC) #2
eae
LGTM
4 years, 8 months ago (2016-04-22 16:52:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913453002/1
4 years, 8 months ago (2016-04-22 16:53:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 17:02:39 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:48:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9ae8afc886232819001f274825a6c55d7fc8482
Cr-Commit-Position: refs/heads/master@{#389144}

Powered by Google App Engine
This is Rietveld 408576698