Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1913433003:
Remove HTMLMediaElement::m_sentEndEvent (Closed)
|
Created:
4 years, 8 months ago by ramya.v Modified:
4 years, 7 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove HTMLMediaElement::m_sentEndEvent
BUG=313165
Committed: https://crrev.com/231384d458995ad9eb7d6d445ff017e0908b07fb
Cr-Commit-Position: refs/heads/master@{#390028}
Patch Set 1 : #
Messages
Total messages: 24 (12 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [WIP] BUG=591267 ========== to ========== Remove HTMLMediaElement::m_sentEndEvent BUG=313165 ==========
ramya.v@samsung.com changed reviewers: + philipj@opera.com
PTAL! Thanks
philipj@opera.com changed reviewers: + fs@opera.com, mlamouri@chromium.org - philipj@opera.com
This is my last week at Opera, so I can't take on any new reviews now, sorry. As I wrote in the issue I think removing this could work out, but there is a regression risk and someone needs to be ready to revert. Leaving to fs and mlamouri.
On 2016/04/26 at 14:38:21, philipj wrote: > This is my last week at Opera, so I can't take on any new reviews now, sorry. > > As I wrote in the issue I think removing this could work out, but there is a regression risk and someone needs to be ready to revert. Leaving to fs and mlamouri. Let's give this a whirl then. LGTM.
The CQ bit was checked by ramya.v@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913433003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by ramya.v@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913433003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
@fs Looks like failure in CQ is with/without patch. Can you please take a look. Thanks
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913433003/40001
It's likely an issue that was temporary.
Message was sent while issue was closed.
Description was changed from ========== Remove HTMLMediaElement::m_sentEndEvent BUG=313165 ========== to ========== Remove HTMLMediaElement::m_sentEndEvent BUG=313165 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove HTMLMediaElement::m_sentEndEvent BUG=313165 ========== to ========== Remove HTMLMediaElement::m_sentEndEvent BUG=313165 Committed: https://crrev.com/231384d458995ad9eb7d6d445ff017e0908b07fb Cr-Commit-Position: refs/heads/master@{#390028} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/231384d458995ad9eb7d6d445ff017e0908b07fb Cr-Commit-Position: refs/heads/master@{#390028} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
