Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4502)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 1913413002: [WIP][POC] Base URL: https://chromium.googlesource.com/chromium/src.git@permission-request-rename
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index 4fdb2cc0defadd9306aec07b19055a5d1a4d074f..21d2f70849e4a6b74623c20cb0f05dcdb49933e6 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -51,6 +51,8 @@
#include "components/tracing/tracing_switches.h"
#include "content/public/browser/web_contents.h"
+#include "chrome/browser/permissions/permission_request_manager.h"
+
#if BUILDFLAG(ANDROID_JAVA_UI)
#include "chrome/browser/android/data_usage/data_use_tab_helper.h"
#include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
@@ -62,7 +64,6 @@
#include "components/offline_pages/offline_page_feature.h"
#else
#include "chrome/browser/banners/app_banner_manager_desktop.h"
-#include "chrome/browser/permissions/permission_request_manager.h"
#include "chrome/browser/plugins/plugin_observer.h"
#include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"
#include "chrome/browser/thumbnails/thumbnail_tab_helper.h"
@@ -177,6 +178,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
// is taken over by ChromeContentSettingsClient. http://crbug.com/387075
TabSpecificContentSettings::CreateForWebContents(web_contents);
+ PermissionRequestManager::CreateForWebContents(web_contents);
+
// --- Platform-specific tab helpers ---
#if BUILDFLAG(ANDROID_JAVA_UI)
@@ -200,7 +203,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(
web_contents, std::unique_ptr<pdf::PDFWebContentsHelperClient>(
new ChromePDFWebContentsHelperClient()));
- PermissionRequestManager::CreateForWebContents(web_contents);
PluginObserver::CreateForWebContents(web_contents);
SadTabHelper::CreateForWebContents(web_contents);
safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);
« no previous file with comments | « chrome/browser/permissions/permission_request_manager.cc ('k') | chrome/browser/ui/website_settings/permission_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698