Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1913373002: Revert "Refactor ProfileInfoCache in most of c/b/profiles" (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Peter Beverloo, asvitkine+watch_chromium.org, posciak+watch_chromium.org, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, mcasas+watch+vc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -611 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/media/tab_desktop_media_list.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 4 chunks +28 lines, -18 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_unittest.cc View 9 chunks +21 lines, -37 lines 0 comments Download
M chrome/browser/profiles/profile_attributes_entry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_attributes_entry.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_attributes_storage.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 4 chunks +49 lines, -47 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_list_desktop_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 20 chunks +81 lines, -89 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 12 chunks +40 lines, -51 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 25 chunks +153 lines, -180 lines 0 comments Download
M chrome/browser/profiles/profile_metrics.cc View 5 chunks +21 lines, -23 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 10 chunks +33 lines, -47 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 7 chunks +18 lines, -25 lines 0 comments Download
M chrome/browser/profiles/profiles_state.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profiles_state.cc View 7 chunks +27 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d27af412217896ba2cc8add011e8272f5b04f34 Cr-Commit-Position: refs/heads/master@{#389305}
4 years, 8 months ago (2016-04-22 23:46:00 UTC) #6
apacible
Committed patchset #1 (id:1) manually as 2d27af412217896ba2cc8add011e8272f5b04f34 (presubmit successful).
4 years, 8 months ago (2016-04-22 23:46:42 UTC) #8
lwchkg
4 years, 8 months ago (2016-04-23 09:50:47 UTC) #9
Message was sent while issue was closed.
On 2016/04/22 23:46:42, apacible wrote:
> Committed patchset #1 (id:1) manually as
> 2d27af412217896ba2cc8add011e8272f5b04f34 (presubmit successful).

Thanks for reverting. I was so stupid to enclose some required code in DCHECK,
so the unit tests crashed when compiled without debug code. Anyway, is it
possible to request adding a trybot doing unit tests on non-debug code?

Powered by Google App Engine
This is Rietveld 408576698