[MD Extensions] Add a details subpage, move to one list

chrome/browser/resources/md_extensions/manager.js

Index: chrome/browser/resources/md_extensions/manager.js
diff --git a/chrome/browser/resources/md_extensions/manager.js b/chrome/browser/resources/md_extensions/manager.js
index 60c33b48dc53929f194694d4549277ace4fc2936..a67b46d79d195853bda6237e8ae11aa2ed6cba66 100644
--- a/chrome/browser/resources/md_extensions/manager.js
+++ b/chrome/browser/resources/md_extensions/manager.js
@@ -60,12 +60,6 @@ cr.define('extensions', function() {
         type: Array,
         value: function() { return []; },
       },
-
-      /** @type {!Array<!chrome.developerPrivate.ExtensionInfo>} */
-      websites: {
-        type: Array,
-        value: function() { return []; },
-      },
     },
 
     behaviors: [
@@ -78,8 +72,8 @@ cr.define('extensions', function() {
           /** @type {extensions.Sidebar} */(this.$$('extensions-sidebar'));
       this.service = extensions.Service.getInstance();
       this.service.managerReady(this);
-      this.scrollHelper_ = new ScrollHelper(this);
-      this.sidebar.setScrollDelegate(this.scrollHelper_);
+      this.listHelper_ = new ListHelper(this);
+      this.sidebar.setListDelegate(this.listHelper_);
       this.$.toolbar.setSearchDelegate(new SearchHelper(this));
     },
 
@@ -94,8 +88,6 @@ cr.define('extensions', function() {
       switch (type) {
         case ExtensionType.HOSTED_APP:
         case ExtensionType.LEGACY_PACKAGED_APP:
-          listId = 'websites';
-          break;
         case ExtensionType.PLATFORM_APP:
           listId = 'apps';
           break;
@@ -125,11 +117,10 @@ cr.define('extensions', function() {
     },
 
     /**
-     * @param {!Array<!chrome.developerPrivate.ExtensionInfo>} list
      * @return {boolean} Whether the list should be visible.
      */
-    computeListHidden_: function(list) {
-      return list.length == 0;
+    computeListHidden_: function(a, b, c, d) {

[Dan Beam, 2016/04/26 01:32:12]

why a, b, c, d with no doc?

[Devlin, 2016/04/26 17:24:18]

Whoops, was debugging.  Removed.

+      return this.$['items-list'].items.length == 0;
     },
 
     /**
@@ -173,34 +164,35 @@ cr.define('extensions', function() {
       assert(index >= 0);
       this.splice(listId, index, 1);
     },
+

[Dan Beam, 2016/04/26 01:32:12]

doc

[Devlin, 2016/04/26 17:24:18]

Done.

+    showDetailsFor: function(data) {
+      this.$['details-view'].set('data', data);
+      this.$.pages.selected = 1;
+    },
+

[Dan Beam, 2016/04/26 01:32:12]

/** @private */

[Devlin, 2016/04/26 17:24:18]

Done.

+    onDetailsViewClose_: function() {
+      this.$.pages.selected = 0;
+    }
   });
 
   /**
    * @param {extensions.Manager} manager

[Dan Beam, 2016/04/26 01:32:12]

a helper that takes a manager and implements a delegate?

this code is starting to get a little confusing

[Devlin, 2016/04/26 17:24:18]

It's okay, we don't yet have Factory, Impl, or half a dozen other generic
pattern names! ;)

Really, this is only needed because we have yet to find a
polymeric-closure-compilable-way of having Manager override another class
directly - ListHelper is entirely an implementation detail of the manager.

    * @constructor
-   * @implements {extensions.SidebarScrollDelegate}
+   * @implements {extensions.SidebarListDelegate}
    */
-  function ScrollHelper(manager) {
-    this.items_ = manager.$.items;
+  function ListHelper(manager) {
+    this.manager = manager;
   }
 
-  ScrollHelper.prototype = {
-    /** @override */
-    scrollToExtensions: function() {
-      this.items_.scrollTop =
-          this.items_.querySelector('#extensions-list').offsetTop;
-    },
-
+  ListHelper.prototype = {
     /** @override */
-    scrollToApps: function() {
-      this.items_.scrollTop =
-          this.items_.querySelector('#apps-list').offsetTop;
+    showExtensions: function() {
+      this.manager.$['items-list'].set('items', this.manager.extensions);

[Dan Beam, 2016/04/26 01:32:12]

why not just ask for for an items list element if it's the only property that's
used from |this.manager|?

[Devlin, 2016/04/26 17:24:18]

We also use manager.extensions and manager.apps.  We could pass in all three,
but it seemed too verbose.  Again, this is really just an implementation detail,
and would be cleaner if we could just put showApps() and showExtensions()
directly on manager, but we can't.  I'm thinking of these as the equivalent of
private inner classes in C++.

     },
 
     /** @override */
-    scrollToWebsites: function() {
-      this.items_.scrollTop =
-          this.items_.querySelector('#websites-list').offsetTop;
+    showApps: function() {
+      this.manager.$['items-list'].set('items', this.manager.apps);
     },
   };