Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: chrome/test/data/webui/extensions/extension_item_test.js

Issue 1913353002: [MD Extensions] Add a details subpage, move to one list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: latest master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/extensions/extension_item_test.js
diff --git a/chrome/test/data/webui/extensions/extension_item_test.js b/chrome/test/data/webui/extensions/extension_item_test.js
index fa61331a4f5e34c39db77b9843c42cc5932e6055..afad0d586792f9cb1cc42fdcfde82809ee0420b1 100644
--- a/chrome/test/data/webui/extensions/extension_item_test.js
+++ b/chrome/test/data/webui/extensions/extension_item_test.js
@@ -22,14 +22,8 @@ cr.define('extension_item_tests', function() {
setItemEnabled: function(id, enabled) {},
/** @override */
- showItemDetails: function(id) {},
-
- /** @override */
setItemAllowedIncognito: function(id, enabled) {},
- /** @override */
- isInDevMode: function() { return false; },
-
/** @override: */
inspectItemView: function(id, view) {},
};
@@ -191,13 +185,21 @@ cr.define('extension_item_tests', function() {
item.$$('#allow-incognito'), 'setItemAllowedIncognito',
[item.data.id, true]);
mockDelegate.testClickingCalls(
- item.$$('#details-button'), 'showItemDetails', [item.data.id]);
- mockDelegate.testClickingCalls(
item.$$('#inspect-views paper-button'),
'inspectItemView', [item.data.id, item.data.views[0]]);
mockDelegate.testClickingCalls(
item.$$('#inspect-views paper-button:nth-of-type(0n + 2)'),
'inspectItemView', [item.data.id, item.data.views[1]]);
+
+ var satisfied = false;
+ var listener = function(e) {
+ expectTrue(e.detail.element == item);
+ satisfied = true;
+ };
+ item.addEventListener('extension-item-show-details', listener);
+ MockInteractions.tap(item.$$('#details-button'));
+ expectTrue(satisfied);
+ item.removeEventListener('extension-item-show-details', listener);
});
test(assert(TestNames.Warnings), function() {

Powered by Google App Engine
This is Rietveld 408576698