[MD Extensions] Add a details subpage, move to one list

chrome/test/data/webui/extensions/extension_sidebar_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for extension-sidebar. */
 cr.define('extension_sidebar_tests', function() {
   /**
    * A mock delegate for the sidebar.
    * @constructor
    * @implements {extensions.SidebarDelegate}
@@ skipping 11 matching lines @@
     /** @override */
     loadUnpacked: function() {},
 
     /** @override */
     packExtension: function() {},
 
     /** @override */
     updateAllExtensions: function() {},
 
     /** @override */
-    scrollToExtensions: function() {},
+    showExtensions: function() {},

[Dan Beam, 2016/04/26 01:32:13]

it's not currently clear from this API that apps and extensions are mutually
exclusive

maybe make an enum mode for the page to be so it's clearer that things are
mutually exclusive, i.e.

/** @enum {number} */
var ShowingType = {
  EXTENSIONS: 1,
  APPS: 2,
};

[Devlin, 2016/04/26 17:24:18]

Done.  For now, I've put ShowingType in sidebar.js, but lemme know if you want
it somewhere else.

 
     /** @override */
-    scrollToApps: function() {},
-
-    /** @override */
-    scrollToWebsites: function() {},
+    showApps: function() {},
   };
 
   /** @enum {string} */
   var TestNames = {
     Layout: 'layout',
     ClickHandlers: 'click handlers',
   };
 
   function registerTests() {
     suite('ExtensionSidebarTest', function() {
       /** @type {MockDelegate} */
       var mockDelegate;
 
       /** @type {extensions.Sidebar} */
       var sidebar;
 
       // Import cr_settings_checkbox.html before running suite.
       suiteSetup(function() {
         return PolymerTest.importHtml('chrome://extensions/sidebar.html');
       });
 
       setup(function() {
         sidebar = document.querySelector('extensions-manager').sidebar;
         mockDelegate = new MockDelegate();
         sidebar.setDelegate(mockDelegate);
-        sidebar.setScrollDelegate(mockDelegate);
+        sidebar.setListDelegate(mockDelegate);
       });
 
       test(assert(TestNames.Layout), function() {
         var testVisible = extension_test_util.testVisible.bind(null, sidebar);
         testVisible('#load-unpacked', false);
         testVisible('#pack-extensions', false);
         testVisible('#update-now', false);
 
         sidebar.set('inDevMode', true);
         Polymer.dom.flush();
@@ skipping 13 matching lines @@
         mockDelegate.testClickingCalls(
             sidebar.$['developer-mode-checkbox'], 'setProfileInDevMode',
             [true]);
         mockDelegate.testClickingCalls(
             sidebar.$$('#load-unpacked'), 'loadUnpacked', []);
         mockDelegate.testClickingCalls(
             sidebar.$$('#pack-extensions'), 'packExtension', []);
         mockDelegate.testClickingCalls(
             sidebar.$$('#update-now'), 'updateAllExtensions', []);
         mockDelegate.testClickingCalls(
-            sidebar.$$('#sections-extensions'), 'scrollToExtensions', []);
+            sidebar.$$('#sections-extensions'), 'showExtensions', []);
         mockDelegate.testClickingCalls(
-            sidebar.$$('#sections-apps'), 'scrollToApps', []);
-        mockDelegate.testClickingCalls(
-            sidebar.$$('#sections-websites'), 'scrollToWebsites', []);
+            sidebar.$$('#sections-apps'), 'showApps', []);
       });
     });
   }
 
   return {
     registerTests: registerTests,
     TestNames: TestNames,
   };
 });