chrome/browser/resources/md_extensions/detail_view.html - Issue 1913353002: [MD Extensions] Add a details subpage, move to one list

Side by Side Diff: chrome/browser/resources/md_extensions/detail_view.html

Issue 1913353002: [MD Extensions] Add a details subpage, move to one list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iron list fixes, menu default selection Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_extensions/compiled_resources.gyp ('K') | « chrome/browser/resources/md_extensions/compiled_resources.gyp ('k') | chrome/browser/resources/md_extensions/detail_view.js » ('j') | chrome/browser/resources/md_extensions/detail_view.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/cr.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3 <link rel="import" href="chrome://resources/html/polymer.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/hero-animation.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/scale-down-animation.html">

	8 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable-behavior.html">

	9

	10 <dom-module id="extensions-detail-view">

	11 <template>

	12 <style>

	13 #main {

	14 background-color: white;

	15 height: 800px;

	16 width: 90%;

	17 }

	18 #top-bar {

	19 align-items: center;

	20 color: #757575;
	Dan Beam 2016/04/26 01:32:12 where are you getting these color values from? ar where are you getting these color values from? are there --paper or --google equivalents? Devlin 2016/04/26 17:24:18 Done. Show quoted text On 2016/04/26 01:32:12, Dan Beam wrote: > where are you getting these color values from? are there --paper or --google > equivalents? Done.
	21 display: flex;

	22 height: 40px;

	23 margin-bottom: 30px;

	24 padding: 8px 12px 0 12px;
	Dan Beam 2016/04/26 01:32:12 nit: padding: 8px 12px 0; nit: padding: 8px 12px 0; Devlin 2016/04/26 17:24:18 One of these days I'll memorize what 3 values mean Show quoted text On 2016/04/26 01:32:12, Dan Beam wrote: > nit: padding: 8px 12px 0; One of these days I'll memorize what 3 values means in margin/padding. Done.
	25 }

	26 #name {

	27 flex-grow: 1;

	28 }

	29 .section {

	30 border-bottom: 1px solid #ccc;

	31 padding: 12px 20px 12px 20px;
	Dan Beam 2016/04/26 01:32:12 nit: padding: 12px 20px; nit: padding: 12px 20px; Devlin 2016/04/26 17:24:18 Done. Show quoted text On 2016/04/26 01:32:12, Dan Beam wrote: > nit: padding: 12px 20px; Done.
	32 }

	33 .section:last-child {

	34 border: none;

	35 }

	36 .section-title {

	37 color: #484848;

	38 }

	39 .section-content {

	40 color: #757575;

	41 }

	42 .checkbox {

	43 --paper-checkbox-checked-color: rgb(66, 133, 244);

	44 --primary-text-color: #5A5A5A;

	45 }

	46 </style>

	47 <div id="main">

	48 <div id="top-bar">

	49 <paper-icon-button id="close-button" icon="arrow-back"

	50 on-click="onCloseButtonClick_"></paper-icon-button>

	51 <span id="name">[[data.name]]</span>

	52 <paper-icon-button id="open-in-webstore" icon="open-in-new">

	53 </paper-icon-button>

	54 <paper-icon-button id="options" icon="settings">

	55 </paper-icon-button>

	56 </div>

	57 <div class="section">

	58 <div class="section-title">[[i18n('itemDescriptionLabel')]]</div>
	Dan Beam 2016/04/26 01:32:12 or you can use $i18n{} ;) or you can use $i18n{} ;) Devlin 2016/04/26 17:24:18 Done. Is that done pre-processing (or what's the Show quoted text On 2016/04/26 01:32:12, Dan Beam wrote: > or you can use $i18n{} ;) Done. Is that done pre-processing (or what's the benefit over this)?
	59 <div class="section-content">[[data.description]]</div>

	60 </div>

	61 <div class="section">

	62 <div class="section-title">[[i18n('itemVersion')]]</div>

	63 <div class="section-content">[[data.version]]</div>

	64 </div>

	65 <div class="section">

	66 <div class="section-title">[[i18n('itemPermissions')]]</div>

	67 <div class="section-content">TODO</div>

	68 </div>

	69 <template is="dom-if" if="[[hasDependentExtensions_(data.*)]]">

	70 <div class="section">

	71 <div class="section-title">[[i18n('itemDependencies')]]</div>

	72 <div class="section-content">TODO</div>

	73 </div>

	74 </template>

	75 <div class="section">

	76 <template is="dom-if" if="[[data.incognitoAccess.isEnabled]]">
	Dan Beam 2016/04/26 01:32:12 don't we want to pu this dom-if around the whole s don't we want to pu this dom-if around the whole section? Devlin 2016/04/26 17:24:18 Hmm... kind of (a lot more controls are gonna go i Show quoted text On 2016/04/26 01:32:12, Dan Beam wrote: > don't we want to pu this dom-if around the whole section? Hmm... kind of (a lot more controls are gonna go in here). Added a different dom-if that can be extended for those controls (I'll have a patch up that uses it later today).
	77 <paper-checkbox id="allow-incognito" class="checkbox"

	78 checked="[[data.incognitoAccess.isActive]]"

	79 on-change="onAllowIncognitoChange_">

	80 [[i18n('itemAllowIncognito')]]

	81 </paper-checkbox>

	82 </template>

	83 </div>

	84 <div class="section">

	85 <div class="section-title">[[i18n('itemSource')]]</div>

	86 <div class="section-content">TODO</div>

	87 </div>

	88 </div>

	89 </template>

	90 <script src="chrome://extensions/detail_view.js"></script>

	91 </dom-module>

OLD	NEW